From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ivpu: Remove disable_d0i3_msg workaround
Date: Wed, 27 May 2026 14:51:17 +1000 [thread overview]
Message-ID: <review-patch1-20260526125521.594479-1-andrzej.kacprowski@linux.intel.com> (raw)
In-Reply-To: <20260526125521.594479-1-andrzej.kacprowski@linux.intel.com>
Patch Review
**Verdict: Looks good.**
**ivpu_drv.h changes:**
- Removes `bool disable_d0i3_msg;` from `struct ivpu_wa_table` — correct, the field is no longer referenced anywhere.
- Removes `IVPU_TEST_MODE_D0I3_MSG_DISABLE BIT(4)` and `IVPU_TEST_MODE_D0I3_MSG_ENABLE BIT(5)` — correct. Note that BIT(4) and BIT(5) are now unused in the test_mode space, which is fine since these are bitmask values and the remaining bits (0-2, 6, 8, 9) keep their positions.
**ivpu_fw.c changes:**
- The entire `ivpu_fw_init_wa()` function is removed. I confirmed via grep that `disable_d0i3_msg` was the **only** workaround handled in this function, so removing the whole function is correct. If this function had handled other workarounds, removing it would have been a bug.
- The call `ivpu_fw_init_wa(vdev)` in `ivpu_fw_init()` is removed — matches the function removal.
- The conditional:
```c
if (!IVPU_WA(disable_d0i3_msg))
boot_params->d0i3_delayed_entry = 1;
```
is simplified to:
```c
boot_params->d0i3_delayed_entry = 1;
```
This unconditionally enables delayed entry, which the commit message explains is the only correct mode for all supported firmware.
- Copyright year bump 2025 → 2026 is appropriate.
**Minor style nit:** The removal of `ivpu_fw_init_wa()` leaves a double blank line (line 348 in the original has `}` closing `ivpu_fw_release`, then two blank lines before `static int ivpu_fw_mem_init`). This is visible in the diff context. Linux kernel style prefers a single blank line between functions. Very minor, not a blocker.
**ivpu_jsm_msg.c changes:**
- Removes the early return guard:
```c
if (IVPU_WA(disable_d0i3_msg))
return 0;
```
This means `ivpu_jsm_pwr_d0i3_enter()` will now always send the IPC message. This is correct — with the workaround removed, the D0i3 entry message should always be sent.
**vpu_boot_api.h changes:**
- `VPU_BOOT_API_VER_PATCH` bumped from 4 to 5. This is a documentation-only change to the API header (the patch version tracks header formatting/comment changes, not ABI changes), which is appropriate since the comment for `d0i3_delayed_entry` is being updated.
- The comment update adds a deprecation note:
```c
* NOTE: This parameter is deprecated starting NPU50xx+. Bit 0 is now hardcoded to 1,
* meaning CPU state save always requires IPC message on D0i3 entry flow.
```
This is good documentation. Also fixes a minor formatting inconsistency (`Bit0:` → `Bit 0:`) for readability.
**Overall:** Clean patch, no functional or correctness issues. The only minor observation is the double blank line left after removing `ivpu_fw_init_wa()`, but that's trivial.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-27 4:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 12:55 [PATCH] accel/ivpu: Remove disable_d0i3_msg workaround Andrzej Kacprowski
2026-05-26 13:03 ` Wachowski, Karol
2026-05-27 4:51 ` Claude Code Review Bot [this message]
2026-05-27 4:51 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260526125521.594479-1-andrzej.kacprowski@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox