public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vkms: Backport generic vblank timer to fix ABBA deadlock
Date: Wed, 27 May 2026 14:49:44 +1000	[thread overview]
Message-ID: <review-overall-20260526133123.691465-1-w15303746062@163.com> (raw)
In-Reply-To: <20260526133123.691465-1-w15303746062@163.com>

Overall Series Review

Subject: drm/vkms: Backport generic vblank timer to fix ABBA deadlock
Author: w15303746062@163.com
Patches: 6
Reviewed: 2026-05-27T14:49:44.274178

---

This is a **stable backport (6.18.y)** of 5 upstream commits that introduce the generic DRM vblank timer infrastructure and convert vkms to use it, fixing an ABBA deadlock between `vblank_time_lock` and `hrtimer_cancel()` in vkms. The original author is Thomas Zimmermann; Mingyu Wang is cherry-picking with appropriate `Signed-off-by` trailers.

All 5 patches are confirmed present in drm-next already (verified by inspecting the kernel tree), so this is a legitimate cherry-pick series. The commit ordering is correct and the dependency chain is sound: patches 1-2 introduce the infrastructure, patch 3 converts vkms, patch 4 fixes a timeout regression from the conversion, and patch 5 is a trivial doc fix.

**Procedural concern:** This series is addressed to `stable@vger.kernel.org` targeting **6.18.y** but 6.18 has not been released yet at time of submission (the -rc cycle would still be ongoing). Stable backports typically target released kernels. These commits should land via the normal merge path through drm-next into 6.18-rc/6.18, not as stable backports. If the author wants them in an already-released stable kernel (e.g., 6.12.y or 6.15.y), the target branch is wrong. If the patches are for the not-yet-released 6.18, they should go through the normal drm tree merge process rather than stable.

**The patches themselves are clean cherry-picks of reviewed/tested upstream code and are technically sound.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-27  4:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 13:31 [PATCH v2 6.18.y 0/5] drm/vkms: Backport generic vblank timer to fix ABBA deadlock w15303746062
2026-05-26 13:31 ` [PATCH v2 6.18.y 1/5] drm/vblank: Add vblank timer w15303746062
2026-05-27  4:49   ` Claude review: " Claude Code Review Bot
2026-05-26 13:31 ` [PATCH v2 6.18.y 2/5] drm/vblank: Add CRTC helpers for simple use cases w15303746062
2026-05-27  4:49   ` Claude review: " Claude Code Review Bot
2026-05-26 13:31 ` [PATCH v2 6.18.y 3/5] drm/vkms: Convert to DRM's vblank timer w15303746062
2026-05-27  4:49   ` Claude review: " Claude Code Review Bot
2026-05-26 13:31 ` [PATCH v2 6.18.y 4/5] drm/atomic: Increase timeout in drm_atomic_helper_wait_for_vblanks() w15303746062
2026-05-27  4:49   ` Claude review: " Claude Code Review Bot
2026-05-26 13:31 ` [PATCH v2 6.18.y 5/5] drm/vblank: Fix kernel docs for vblank timer w15303746062
2026-05-27  4:49   ` Claude review: " Claude Code Review Bot
2026-05-27  4:49 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-25 13:16 [PATCH 6.18.y 0/5] drm/vkms: Backport generic vblank timer to fix ABBA deadlock w15303746062
2026-05-25 21:07 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260526133123.691465-1-w15303746062@163.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox