From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vkms: Convert to DRM's vblank timer
Date: Wed, 27 May 2026 14:49:45 +1000 [thread overview]
Message-ID: <review-patch3-20260526133123.691465-4-w15303746062@163.com> (raw)
In-Reply-To: <20260526133123.691465-4-w15303746062@163.com>
Patch Review
Cherry-pick of upstream `02e2681ffe1addde1fc8c35d05657b16bfa79613`.
Removes vkms's open-coded hrtimer vblank simulation and replaces it with the generic infrastructure from patches 1-2. The old `vkms_vblank_simulate()` hrtimer callback becomes `vkms_crtc_handle_vblank_timeout()` (returning `bool` instead of `enum hrtimer_restart`), keeping only the vkms-specific compositor scheduling logic. The hrtimer forwarding, overrun handling, and timer lifecycle are now in the DRM core.
The vkms-specific `atomic_flush` is kept (not replaced with the generic one from patch 2) because vkms has additional composer/CRC logic there. This is correct.
Removes `vblank_hrtimer` and `period_ns` from `struct vkms_output`.
**No issues.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-27 4:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 13:31 [PATCH v2 6.18.y 0/5] drm/vkms: Backport generic vblank timer to fix ABBA deadlock w15303746062
2026-05-26 13:31 ` [PATCH v2 6.18.y 1/5] drm/vblank: Add vblank timer w15303746062
2026-05-27 4:49 ` Claude review: " Claude Code Review Bot
2026-05-26 13:31 ` [PATCH v2 6.18.y 2/5] drm/vblank: Add CRTC helpers for simple use cases w15303746062
2026-05-27 4:49 ` Claude review: " Claude Code Review Bot
2026-05-26 13:31 ` [PATCH v2 6.18.y 3/5] drm/vkms: Convert to DRM's vblank timer w15303746062
2026-05-27 4:49 ` Claude Code Review Bot [this message]
2026-05-26 13:31 ` [PATCH v2 6.18.y 4/5] drm/atomic: Increase timeout in drm_atomic_helper_wait_for_vblanks() w15303746062
2026-05-27 4:49 ` Claude review: " Claude Code Review Bot
2026-05-26 13:31 ` [PATCH v2 6.18.y 5/5] drm/vblank: Fix kernel docs for vblank timer w15303746062
2026-05-27 4:49 ` Claude review: " Claude Code Review Bot
2026-05-27 4:49 ` Claude review: drm/vkms: Backport generic vblank timer to fix ABBA deadlock Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260526133123.691465-4-w15303746062@163.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox