Claude review: drm/vkms: Backport generic vblank timer to fix ABBA deadlock

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/vkms: Backport generic vblank timer to fix ABBA deadlock
Author: w15303746062@163.com
Patches: 12
Reviewed: 2026-05-26T07:07:30.521650

---

This mbox contains two submissions from Mingyu Wang:

1. **A standalone patch** (May 15) — a minimal fix using `hrtimer_try_to_cancel()` to address an ABBA deadlock in the vkms vblank timer.
2. **A 5-patch series** (May 25) — cherry-picks of Thomas Zimmermann's mainline commits that backport the generic DRM vblank timer infrastructure to 6.18.y, replacing the custom vkms timer entirely.

The series is the correct approach, as confirmed by discussion with Greg KH and Maarten Lankhorst on the mailing list. The standalone patch was the earlier attempt that was superseded. The cherry-picks correspond to well-tested mainline commits with proper Reviewed-by/Tested-by tags.

**Positives:**
- The dependency chain is correctly ordered (infrastructure first, conversion second, followup fixes last).
- Each patch has a proper mainline commit reference for traceability.
- The series resolves a real syzkaller-found ABBA deadlock between `vblank_time_lock` and the hrtimer callback.
- The code in drm-next confirms these exact changes already landed upstream.

**Concerns:**
- This is a substantial amount of new infrastructure for a stable backport (~470 lines added). While the maintainers approved this approach, it carries more regression risk than the minimal fix.
- The series was noted as not applying cleanly to drm-next (expected, since drm-next already has these commits), but the submitter claims it applies cleanly to 6.18.y — this should be verified by the stable maintainers.
- Minor process note: the backporter (Mingyu Wang) does not add their own Signed-off-by on the cherry-picked patches, which is conventional for `git cherry-pick -x` but some stable trees expect an explicit sign-off from the submitter.

**Verdict:** The series looks technically correct as a faithful backport of mainline commits. Acceptable for 6.18.y stable if it applies cleanly there.

---

---
Generated by Claude Code Patch Reviewer