Claude review: Re:Re: [PATCH 6.18.y] drm/vkms: Fix ABBA deadlock in vblank disable and timer callback

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

*(cherry-pick of 02e2681ffe1addde1fc8c35d05657b16bfa79613)*

This is the payoff patch — removes all of vkms' custom vblank timer code and replaces it with the framework. Key changes:

- Removes `vkms_vblank_simulate()`, `vkms_enable_vblank()`, `vkms_disable_vblank()`, `vkms_get_vblank_timestamp()`, `vkms_crtc_atomic_enable()`, `vkms_crtc_atomic_disable()`
- Adds `vkms_crtc_handle_vblank_timeout()` (the custom part vkms still needs for CRC/writeback)
- Uses `DRM_CRTC_VBLANK_TIMER_FUNCS` in `vkms_crtc_funcs`
- Uses `drm_crtc_vblank_atomic_enable/disable` in helper funcs
- Removes `vblank_hrtimer` and `period_ns` from `struct vkms_output`

The conversion is correct. The custom `handle_vblank_timeout` preserves vkms' compositor-triggering logic (the `drm_crtc_handle_vblank()` call plus workqueue scheduling for CRC generation), while delegating all timer management to the framework.

**Note:** The patch correctly keeps `vkms_crtc_atomic_flush` (not replaced by the helper) because vkms has custom flush logic for CRC source handling. Only `atomic_enable`/`atomic_disable` use the generic helpers.

No issues. Clean cherry-pick.

---

---
Generated by Claude Code Patch Reviewer