From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH 6.18.y] drm/vkms: Fix ABBA deadlock in vblank disable and timer callback
Date: Tue, 26 May 2026 07:07:31 +1000 [thread overview]
Message-ID: <review-patch2-2026051557-thermal-petite-7da0@gregkh> (raw)
In-Reply-To: <2026051557-thermal-petite-7da0@gregkh>
Patch Review
*(cherry-pick of d54dbb5963bdbdf8559903fe2b2343e871adcb30)*
Adds generic atomic_flush/enable/disable helpers and the `DRM_CRTC_HELPER_VBLANK_FUNCS` macro. The implementations are straightforward wrappers:
```c
void drm_crtc_vblank_atomic_enable(struct drm_crtc *crtc, ...) {
drm_crtc_vblank_on(crtc);
}
void drm_crtc_vblank_atomic_disable(struct drm_crtc *crtc, ...) {
drm_crtc_vblank_off(crtc);
}
```
The `atomic_flush` helper handles vblank event delivery with proper `event_lock` protection and the standard `vblank_get`/`arm` pattern.
**Minor nit:** The doc overview has a typo "coveniently" (should be "conveniently") — inherited from mainline.
No issues. Clean cherry-pick.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 21:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 13:18 [PATCH 6.18.y] drm/vkms: Fix ABBA deadlock in vblank disable and timer callback w15303746062
2026-05-15 15:09 ` Greg KH
2026-05-16 2:43 ` w15303746062
2026-05-16 9:51 ` Greg KH
2026-05-18 2:22 ` w15303746062
2026-05-25 8:55 ` Maarten Lankhorst
2026-05-25 13:16 ` [PATCH 6.18.y 0/5] drm/vkms: Backport generic vblank timer to fix ABBA deadlock w15303746062
2026-05-25 13:16 ` [PATCH 6.18.y 1/5] drm/vblank: Add vblank timer w15303746062
2026-05-25 13:16 ` [PATCH 6.18.y 2/5] drm/vblank: Add CRTC helpers for simple use cases w15303746062
2026-05-25 13:16 ` [PATCH 6.18.y 3/5] drm/vkms: Convert to DRM's vblank timer w15303746062
2026-05-25 13:16 ` [PATCH 6.18.y 4/5] drm/atomic: Increase timeout in drm_atomic_helper_wait_for_vblanks() w15303746062
2026-05-25 13:16 ` [PATCH 6.18.y 5/5] drm/vblank: Fix kernel docs for vblank timer w15303746062
2026-05-25 21:07 ` Claude review: drm/vkms: Backport generic vblank timer to fix ABBA deadlock Claude Code Review Bot
2026-05-25 21:07 ` Claude review: Re:Re: Re: [PATCH 6.18.y] drm/vkms: Fix ABBA deadlock in vblank disable and timer callback Claude Code Review Bot
2026-05-25 21:07 ` Claude review: " Claude Code Review Bot
2026-05-25 21:07 ` Claude review: " Claude Code Review Bot
2026-05-25 21:07 ` Claude Code Review Bot [this message]
2026-05-15 23:05 ` Claude review: " Claude Code Review Bot
2026-05-15 23:05 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-2026051557-thermal-petite-7da0@gregkh \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox