Claude review: gpu: drm: nova: enable calling into nova-core

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: gpu: drm: nova: enable calling into nova-core
Author: Alexandre Courbot <acourbot@nvidia.com>
Patches: 11
Reviewed: 2026-05-28T12:21:59.491666

---

This is a well-structured 7-patch series enabling `nova-drm` to call into `nova-core` as an interim workaround until the Rust build system natively supports cross-crate module dependencies. The approach is pragmatic: export Rust symbols via generated C `EXPORT_SYMBOL_GPL()` calls, generate `.rmeta` metadata for compile-time type resolution, and wire up the Makefile dependencies. The first three patches are preparatory fixes (modpost truncation detection, inlining to shrink symbol names) and the final patch is an explicitly-labeled POC not intended for merge.

**Key concerns:**

1. The modpost fix (patch 1) has a correctness issue with printing `tmp` after truncation — the content is already truncated/partial and may confuse developers.
2. The `#[inline(always)]` patches are reasonable workarounds but scatter hints across core Rust infrastructure to fix a Nova-specific symbol length problem — this should be discussed with the Rust-for-Linux maintainers since it affects all kernel Rust users.
3. The POC patch (7/7) has significant issues with self-referential struct field ordering and `SAFETY` comments that don't fully address the concerns.

Overall, patches 1-6 are in reasonable shape for a stated workaround. Patch 7 needs rework if it were ever to be merged, but it's explicitly labeled as a POC.

---
Generated by Claude Code Patch Reviewer