From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: DSC max delta bpp support
Date: Thu, 28 May 2026 12:24:07 +1000 [thread overview]
Message-ID: <review-overall-20260527110849.3943338-1-nemesa.garg@intel.com> (raw)
In-Reply-To: <20260527110849.3943338-1-nemesa.garg@intel.com>
Overall Series Review
Subject: DSC max delta bpp support
Author: Nemesa Garg <nemesa.garg@intel.com>
Patches: 5
Reviewed: 2026-05-28T12:24:07.251231
---
This 4-patch series adds support for decoding DSC maximum bpp from the delta-based DPCD field (register 0x06E) for DP sinks that expose this capability. The series is logically structured: fix the register placement in drm_dp.h, rename for spec alignment, add computation constants, then use them in intel_dp.c. The concept is sound and the patches are a reasonable size.
However, there are several issues worth flagging: the YCbCr422 mask is placed under the wrong register, there's a potential logic bug where an out-of-range delta value silently returns an uninitialized-looking result, and the naming of the new delta constants is inconsistent.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-28 2:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 11:08 [PATCH 0/4] DSC max delta bpp support Nemesa Garg
2026-05-27 11:08 ` [PATCH 1/4] drm/dp: Add DP_DSC_MAX_BPP_DELTA register Nemesa Garg
2026-05-28 2:24 ` Claude review: " Claude Code Review Bot
2026-05-27 11:08 ` [PATCH 2/4] drm/dp: Rename YCbCr420 bpp delta mask to native Nemesa Garg
2026-05-28 2:24 ` Claude review: " Claude Code Review Bot
2026-05-27 11:08 ` [PATCH 3/4] drm/dp: Add max bpp delta computation constants Nemesa Garg
2026-05-28 2:24 ` Claude review: " Claude Code Review Bot
2026-05-27 11:08 ` [PATCH 4/4] drm/i915/dp: Decode dsc max delta bpp from sink dpcd Nemesa Garg
2026-05-28 2:24 ` Claude review: " Claude Code Review Bot
2026-05-28 2:24 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-20 11:26 [PATCH 0/2] DSC max delta bpp support Nemesa Garg
2026-04-23 0:06 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260527110849.3943338-1-nemesa.garg@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox