public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: DSC max delta bpp support
Date: Thu, 23 Apr 2026 10:06:54 +1000	[thread overview]
Message-ID: <review-overall-20260420112611.1481530-1-nemesa.garg@intel.com> (raw)
In-Reply-To: <20260420112611.1481530-1-nemesa.garg@intel.com>

Overall Series Review

Subject: DSC max delta bpp support
Author: Nemesa Garg <nemesa.garg@intel.com>
Patches: 5
Reviewed: 2026-04-23T10:06:54.839347

---

This 2-patch series adds support for decoding DSC maximum bpp from the delta-based DPCD fields (register 0x06E) defined in eDP 1.5 / DP 2.0. The goal is reasonable — some sinks only expose max bpp via the delta encoding rather than the absolute DPCD 0x067/0x068 fields.

However, the series has a **correctness bug** (reserved 444 delta values produce garbage output), **naming convention violations** in the shared DRM header, and questionable placement of driver-specific decode constants in the common `drm_dp.h`. The series needs a respin.

**Key issues:**
- Reserved delta values (22–31) for RGB/YCbCr444 are silently passed through without decoding, producing wrong max bpp values.
- New macro names in `drm_dp.h` break the `DP_DSC_` naming convention used throughout the file.
- Driver-specific decode constants don't belong in the shared DPCD header.

---

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-23  0:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 11:26 [PATCH 0/2] DSC max delta bpp support Nemesa Garg
2026-04-20 11:26 ` [PATCH 1/2] drm/dp: Define DSC bpp delta DPCD fields Nemesa Garg
2026-04-21  6:34   ` Nautiyal, Ankit K
2026-04-23  0:06   ` Claude review: " Claude Code Review Bot
2026-04-20 11:26 ` [PATCH 2/2] drm/i915/dp: Decode DSC max delta bpp from sink DPCD Nemesa Garg
2026-04-21 10:50   ` Nautiyal, Ankit K
2026-04-23  0:06   ` Claude review: " Claude Code Review Bot
2026-04-23  0:06 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260420112611.1481530-1-nemesa.garg@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox