From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/exec: drm_exec.h: eliminate kernel-doc warnings
Date: Thu, 28 May 2026 12:04:23 +1000 [thread overview]
Message-ID: <review-overall-20260527220018.1231829-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260527220018.1231829-1-rdunlap@infradead.org>
Overall Series Review
Subject: drm/exec: drm_exec.h: eliminate kernel-doc warnings
Author: Randy Dunlap <rdunlap@infradead.org>
Patches: 1
Reviewed: 2026-05-28T12:04:23.470549
---
This is a single-patch series from Randy Dunlap fixing kernel-doc warnings in `include/drm/drm_exec.h`. The patch is trivial and correct — it addresses two distinct kernel-doc issues:
1. **Missing `Returns:` tag** — kernel-doc requires `Returns:` (with colon) rather than just `Returns` for return value documentation.
2. **Parameter name mismatch** — the `drm_exec_retry()` macro uses `_exec` as its parameter name but the kernel-doc documented it as `@exec`.
Both fixes are mechanical and match the actual code. The Fixes tag references `bba175a2d4be ("drm/exec, drm/xe: Avoid abusing the drm_exec retry pointer")` which introduced `drm_exec_retry()` with the underscore-prefixed parameter and the `drm_exec_is_contended()` return value issue. Note: The patches did not apply to the drm-next tree because the referenced commit (which adds `drm_exec_retry()`) has not yet landed on drm-next — the tree only has `drm_exec_retry_on_contention`, not `drm_exec_retry`.
**Verdict: Patch looks good.** No functional concerns.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-28 2:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 22:00 [PATCH] drm/exec: drm_exec.h: eliminate kernel-doc warnings Randy Dunlap
2026-05-28 2:04 ` Claude review: " Claude Code Review Bot
2026-05-28 2:04 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260527220018.1231829-1-rdunlap@infradead.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox