From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/exec: drm_exec.h: eliminate kernel-doc warnings
Date: Thu, 28 May 2026 12:04:23 +1000 [thread overview]
Message-ID: <review-patch1-20260527220018.1231829-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260527220018.1231829-1-rdunlap@infradead.org>
Patch Review
**Change 1 — `Returns` → `Returns:`** (line 88 of the mbox)
```diff
- * Returns true if the drm_exec object has run into some contention while
+ * Returns: true if the drm_exec object has run into some contention while
```
Correct. The kernel-doc parser requires the `Returns:` keyword (with colon) to properly recognize and format return value descriptions. Without the colon, kernel-doc emits:
```
Warning: include/drm/drm_exec.h:146 No description found for return value of 'drm_exec_is_contended'
```
**Change 2 — `@exec` → `@_exec`** (line 97 of the mbox)
```diff
- * @exec: drm_exec object
+ * @_exec: drm_exec object
```
Correct. The `drm_exec_retry()` macro uses `_exec` as its parameter name (with leading underscore, a common pattern for macro arguments to avoid shadowing), but the kernel-doc comment documented it as `@exec`. This mismatch produces two warnings — the actual parameter `_exec` is undescribed and `exec` is flagged as excess. The fix aligns the documentation with the actual parameter name.
**No issues found.** Both changes are straightforward kernel-doc documentation fixes with no functional impact.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-28 2:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 22:00 [PATCH] drm/exec: drm_exec.h: eliminate kernel-doc warnings Randy Dunlap
2026-05-28 2:04 ` Claude review: " Claude Code Review Bot
2026-05-28 2:04 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260527220018.1231829-1-rdunlap@infradead.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox