From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/omap: dsi: avoid sending bta sync all the time in writes
Date: Thu, 04 Jun 2026 16:00:55 +1000 [thread overview]
Message-ID: <review-overall-20260529-vm-upstr-v2-1-24c30671719f@kernel.org> (raw)
In-Reply-To: <20260529-vm-upstr-v2-1-24c30671719f@kernel.org>
Overall Series Review
Subject: drm/omap: dsi: avoid sending bta sync all the time in writes
Author: akemnade@kernel.org
Patches: 1
Reviewed: 2026-06-04T16:00:55.211314
---
This is a single-patch fix for the OMAP DSI driver, addressing a real hardware issue with bridge chips (TC358762) that cannot respond to BTA sync requests before they are fully configured. The approach is sound: stop unconditionally sending BTA sync on every write, and instead wait for the PACKET_SENT IRQ for long packets (to avoid FIFO overflows) and skip waiting entirely for short packets. The command-mode update path is fixed to use a bare BTA sync instead of a NOP (which would no longer trigger BTA sync after this change).
The patch is well-motivated, has been tested on both video mode (OMAP4 BT-200) and command mode (droid4), and carries a Tested-by. The overall design is correct, though there are a few issues worth noting.
**Verdict:** Mostly good. A couple of minor issues, one potential race concern.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 6:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 20:19 [PATCH v2] drm/omap: dsi: avoid sending bta sync all the time in writes akemnade
2026-06-04 6:00 ` Claude Code Review Bot [this message]
2026-06-04 6:00 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260529-vm-upstr-v2-1-24c30671719f@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox