public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: YUV support for VOP2 background color
Date: Thu, 04 Jun 2026 13:48:14 +1000	[thread overview]
Message-ID: <review-overall-20260601-vop2-bg-yuv-v2-0-e5aef1d16fec@collabora.com> (raw)
In-Reply-To: <20260601-vop2-bg-yuv-v2-0-e5aef1d16fec@collabora.com>

Overall Series Review

Subject: YUV support for VOP2 background color
Author: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Patches: 7
Reviewed: 2026-06-04T13:48:14.989595

---

This is a clean, well-structured 2-patch series that adds YUV format support for the VOP2 background color register. The motivation is clear: when the VOP2 overlay operates in YUV mode, the background color must also be programmed in YUV, but previously only RGB was supported.

**Patch 1** is a trivial naming consistency fix. **Patch 2** is the substantive change, adding RGB-to-YCbCr conversion matrices derived from the well-established `v4l2-tpg-core.c` reference implementation. The conversion math is correct (verified against the BT.601/709/2020 standards), and the 16-bit precision arithmetic properly accounts for both limited and full range encoding.

The refactoring of `vop2_post_config` to thread explicit old/new state pointers (rather than relying on `crtc->state`) is a good cleanup. The optimization to skip background color reprogramming when neither the color nor the colorspace changed is sensible.

**No blocking issues found.** A couple of minor observations below.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  3:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 18:00 [PATCH v2 0/2] YUV support for VOP2 background color Cristian Ciocaltea
2026-06-01 18:00 ` [PATCH v2 1/2] drm/rockchip: vop2: Rename CSC_BT2020 to CSC_BT2020L Cristian Ciocaltea
2026-06-02 13:25   ` Andy Yan
2026-06-04  3:48   ` Claude review: " Claude Code Review Bot
2026-06-01 18:00 ` [PATCH v2 2/2] drm/rockchip: vop2: Add YUV support to background color Cristian Ciocaltea
2026-06-02 13:25   ` Andy Yan
2026-06-04  3:48   ` Claude review: " Claude Code Review Bot
2026-06-01 18:08 ` [PATCH v2 0/2] YUV support for VOP2 " Cristian Ciocaltea
2026-06-02 18:47 ` Heiko Stuebner
2026-06-04  3:48 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-24 16:27 [PATCH " Cristian Ciocaltea
2026-05-25  7:00 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260601-vop2-bg-yuv-v2-0-e5aef1d16fec@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox