Claude review: drm/vblank: timer: Fix timestamps and improve reliabilty

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/vblank: timer: Fix timestamps and improve reliabilty
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 11
Reviewed: 2026-06-04T14:03:58.367915

---

This series fixes timestamps and improves reliability for the DRM vblank timer infrastructure, used by virtual/software GPU drivers (vkms, bochs, virtio, vmwgfx). The intent is sound — the timestamp calculation has long-standing issues, and the improvements are worthwhile.

However, **Patch 3 introduces a clock domain mismatch bug** that affects multiple subsequent patches. The timer is switched to `CLOCK_BOOTTIME`, but the initial timer start and various timestamp reads/comparisons still use `ktime_get()` / `ktime_get_ns()` which return `CLOCK_MONOTONIC` time. On any system that has been suspended, boottime and monotonic time diverge, making the comparisons invalid. This is the most critical issue in the series.

Additionally, **Patch 1 does not update the vmwgfx caller** (`vmw_vkms_get_vblank_timestamp`), which still ignores the new return value and will return `true` with stale/uninitialized `vblank_time` on error.

The refactoring patches (4, 7) are reasonable, and Patch 6 is a correct and clear bugfix. Patch 2's timestamp correction logic is sound in principle.

---

---
Generated by Claude Code Patch Reviewer