public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vblank: timer: Use absolute timer since boot
Date: Thu, 04 Jun 2026 14:03:59 +1000	[thread overview]
Message-ID: <review-patch3-20260601141922.91498-4-tzimmermann@suse.de> (raw)
In-Reply-To: <20260601141922.91498-4-tzimmermann@suse.de>

Patch Review

**Critical issue: Clock domain mismatch.** The timer is changed from `CLOCK_MONOTONIC` to `CLOCK_BOOTTIME`, but the initial start time uses `ktime_get_ns()`, which returns `CLOCK_MONOTONIC` time:

```c
hrtimer_setup(&vtimer->timer, drm_vblank_timer_function,
              CLOCK_BOOTTIME, HRTIMER_MODE_ABS);
...
vblank_time_ns = roundup(ktime_get_ns(), vblank->framedur_ns);
hrtimer_start(&vtimer->timer, ns_to_ktime(vblank_time_ns), HRTIMER_MODE_ABS);
```

This should be `ktime_get_boottime_ns()`. After any system suspend, `CLOCK_BOOTTIME > CLOCK_MONOTONIC`, so a monotonic timestamp used as a boottime absolute value would be in the past, causing the timer to fire immediately and then forward rapidly.

This mismatch also breaks the comparison in the existing `drm_crtc_vblank_get_vblank_timeout()`: `vtimer->timer.node.expires` is now in the boottime domain, while `cur_time` from `drm_crtc_vblank_count_and_time()` is in the monotonic domain (vblank timestamps are stored via `ktime_get()` in the vblank core). The `!ktime_compare(*vblank_time, cur_time)` check compares values from different clock domains.

**Division by zero risk:** If `vblank->framedur_ns` is 0 (e.g., dotclock is 0), `roundup(ktime_get_ns(), 0)` will trigger a division by zero. The `drm_calc_timestamping_constants` called just before can leave `framedur_ns` at 0 if `dotclock <= 0`. A guard is needed.

**The underrun detection** (`!ret_overrun` case) is a nice addition for debugging.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  4:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 14:08 [PATCH 0/7] drm/vblank: timer: Fix timestamps and improve reliabilty Thomas Zimmermann
2026-06-01 14:08 ` [PATCH 1/7] drm/vblank: timer: Return success status from get_vblank_timeout Thomas Zimmermann
2026-06-04  4:03   ` Claude review: " Claude Code Review Bot
2026-06-01 14:08 ` [PATCH 2/7] drm/vblank: timer: Fix timestamp calculation Thomas Zimmermann
2026-06-01 16:24   ` Michel Dänzer
2026-06-01 17:30     ` Thomas Zimmermann
2026-06-02 14:14       ` Michel Dänzer
2026-06-04  4:03   ` Claude review: " Claude Code Review Bot
2026-06-01 14:08 ` [PATCH 3/7] drm/vblank: timer: Use absolute timer since boot Thomas Zimmermann
2026-06-04  4:03   ` Claude Code Review Bot [this message]
2026-06-01 14:08 ` [PATCH 4/7] drm/vblank: timer: Reorganize get_vblank_timeout Thomas Zimmermann
2026-06-04  4:03   ` Claude review: " Claude Code Review Bot
2026-06-01 14:08 ` [PATCH 5/7] drm/vblank: timer: Estimate vblank timeout if timer is disabled Thomas Zimmermann
2026-06-04  4:03   ` Claude review: " Claude Code Review Bot
2026-06-01 14:08 ` [PATCH 6/7] drm/vblank: timer: Verify that expiry time is in the future Thomas Zimmermann
2026-06-04  4:03   ` Claude review: " Claude Code Review Bot
2026-06-01 14:08 ` [PATCH 7/7] drm/vblank: timer: Avoid reading the vblank time unnecessarily Thomas Zimmermann
2026-06-04  4:04   ` Claude review: " Claude Code Review Bot
2026-06-04  4:03 ` Claude review: drm/vblank: timer: Fix timestamps and improve reliabilty Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260601141922.91498-4-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox