From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: RPM, perfcnt and other minor fixes for Panfrost
Date: Fri, 05 Jun 2026 06:16:23 +1000 [thread overview]
Message-ID: <review-overall-20260604-claude-fixes-v2-0-57c6bd4c1655@collabora.com> (raw)
In-Reply-To: <20260604-claude-fixes-v2-0-57c6bd4c1655@collabora.com>
Overall Series Review
Subject: RPM, perfcnt and other minor fixes for Panfrost
Author: =?utf-8?q?Adri=C3=A1n_Larumbe?= <adrian.larumbe@collabora.com>
Patches: 19
Reviewed: 2026-06-05T06:16:23.718180
---
This is a 7-patch series for the Panfrost GPU driver addressing RPM (Runtime Power Management) reference counting, perfcnt reset handling, and several minor robustness fixes. The series is well-structured with preparatory refactoring patches (3, 4) separated from the actual fixes (5, 6, 7). The two most important patches are patch 6 (PM usage_count fix) and patch 5 (perfcnt reset handling), which address real bugs.
There is one clear **bug** in patch 5 (missing negative return value), and a few design concerns around the perfcnt reset atomics that warrant discussion. The minor patches (1, 2, 3, 4) are straightforward and look correct.
Overall the series is in reasonable shape but patch 5 needs a fix before it can be merged.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-06-04 20:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 17:35 [PATCH v2 0/7] RPM, perfcnt and other minor fixes for Panfrost Adrián Larumbe
2026-06-04 17:35 ` [PATCH v2 1/7] drm/panfrost: Check another bo field for cache option query Adrián Larumbe
2026-06-04 17:57 ` Boris Brezillon
2026-06-04 20:16 ` Claude review: " Claude Code Review Bot
2026-06-04 17:35 ` [PATCH v2 2/7] drm/panfrost: Prevent division by 0 Adrián Larumbe
2026-06-04 17:44 ` sashiko-bot
2026-06-04 20:16 ` Claude review: " Claude Code Review Bot
2026-06-04 18:02 ` Boris Brezillon
2026-06-04 17:35 ` [PATCH v2 3/7] drm/panfrost: Move shrinker initialization and unplug one level down Adrián Larumbe
2026-06-04 18:04 ` Boris Brezillon
2026-06-04 20:16 ` Claude review: " Claude Code Review Bot
2026-06-04 17:35 ` [PATCH v2 4/7] drm/panfrost: Move perfcnt GPU disable sequence into a helper Adrián Larumbe
2026-06-04 17:47 ` sashiko-bot
2026-06-04 20:16 ` Claude review: " Claude Code Review Bot
2026-06-04 18:05 ` Boris Brezillon
2026-06-04 17:35 ` [PATCH v2 5/7] drm/panfrost: Make reset sequence deal with an active HWPerf session Adrián Larumbe
2026-06-04 17:49 ` sashiko-bot
2026-06-04 20:16 ` Claude review: " Claude Code Review Bot
2026-06-04 18:26 ` Boris Brezillon
2026-06-04 17:35 ` [PATCH v2 6/7] drm/panfrost: Fix PM usage_count mishandling Adrián Larumbe
2026-06-04 17:50 ` sashiko-bot
2026-06-04 20:16 ` Claude review: " Claude Code Review Bot
2026-06-04 18:36 ` Boris Brezillon
2026-06-04 17:35 ` [PATCH v2 7/7] drm/panfrost: Explicitly enable MMU interrupts at device init Adrián Larumbe
2026-06-04 17:55 ` sashiko-bot
2026-06-04 20:16 ` Claude review: " Claude Code Review Bot
2026-06-04 20:16 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260604-claude-fixes-v2-0-57c6bd4c1655@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox