public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panfrost: Explicitly enable MMU interrupts at device init
Date: Fri, 05 Jun 2026 06:16:25 +1000	[thread overview]
Message-ID: <review-patch7-20260604-claude-fixes-v2-7-57c6bd4c1655@collabora.com> (raw)
In-Reply-To: <20260604-claude-fixes-v2-7-57c6bd4c1655@collabora.com>

Patch Review

**Verdict: Correct, follows naturally from patch 6.**

```c
int panfrost_mmu_init(struct panfrost_device *pfdev)
{
    ...
    panfrost_mmu_enable_interrupts(pfdev);
    return 0;
}
```

Since patch 6 ensures the device starts active (with PM get/put around probe), there's a window between `drm_dev_register()` and when autosuspend triggers the first `runtime_suspend`/`runtime_resume` cycle. During this window, jobs could be submitted but MMU interrupts weren't enabled (they're only enabled in `panfrost_mmu_reset()`, called from `panfrost_device_reset()`, called from `runtime_resume()`). This patch closes that gap.

The refactoring of `mmu_write` calls into `panfrost_mmu_enable_interrupts()` is clean and used in both `panfrost_mmu_reset()` and `panfrost_mmu_init()`.

---

## SUMMARY OF ISSUES

1. **Patch 5 — Bug:** `ret = EAGAIN` must be `ret = -EAGAIN` (line ~988 in the mbox)
2. **Patch 5 — Bug:** `err_disable` error path leaks the AS reference from `panfrost_mmu_as_get()` — needs `panfrost_mmu_as_put()` before falling through to `err_vunmap`
3. **Patch 4 — Note:** Register write ordering changed in `disable_locked` (enable regs vs config reg) — verify HW is order-agnostic
4. **Patch 5 — Design:** `panfrost_perfcnt_reset()` writes GPU registers without locking — acceptable given the subsequent soft reset, but should be explicitly noted

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04 20:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 17:35 [PATCH v2 0/7] RPM, perfcnt and other minor fixes for Panfrost Adrián Larumbe
2026-06-04 17:35 ` [PATCH v2 1/7] drm/panfrost: Check another bo field for cache option query Adrián Larumbe
2026-06-04 17:57   ` Boris Brezillon
2026-06-04 20:16   ` Claude review: " Claude Code Review Bot
2026-06-04 17:35 ` [PATCH v2 2/7] drm/panfrost: Prevent division by 0 Adrián Larumbe
2026-06-04 17:44   ` sashiko-bot
2026-06-04 20:16     ` Claude review: " Claude Code Review Bot
2026-06-04 18:02   ` Boris Brezillon
2026-06-04 17:35 ` [PATCH v2 3/7] drm/panfrost: Move shrinker initialization and unplug one level down Adrián Larumbe
2026-06-04 18:04   ` Boris Brezillon
2026-06-04 20:16   ` Claude review: " Claude Code Review Bot
2026-06-04 17:35 ` [PATCH v2 4/7] drm/panfrost: Move perfcnt GPU disable sequence into a helper Adrián Larumbe
2026-06-04 17:47   ` sashiko-bot
2026-06-04 20:16     ` Claude review: " Claude Code Review Bot
2026-06-04 18:05   ` Boris Brezillon
2026-06-04 17:35 ` [PATCH v2 5/7] drm/panfrost: Make reset sequence deal with an active HWPerf session Adrián Larumbe
2026-06-04 17:49   ` sashiko-bot
2026-06-04 20:16     ` Claude review: " Claude Code Review Bot
2026-06-04 18:26   ` Boris Brezillon
2026-06-04 17:35 ` [PATCH v2 6/7] drm/panfrost: Fix PM usage_count mishandling Adrián Larumbe
2026-06-04 17:50   ` sashiko-bot
2026-06-04 20:16     ` Claude review: " Claude Code Review Bot
2026-06-04 18:36   ` Boris Brezillon
2026-06-04 17:35 ` [PATCH v2 7/7] drm/panfrost: Explicitly enable MMU interrupts at device init Adrián Larumbe
2026-06-04 17:55   ` sashiko-bot
2026-06-04 20:16   ` Claude Code Review Bot [this message]
2026-06-04 20:16 ` Claude review: RPM, perfcnt and other minor fixes for Panfrost Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch7-20260604-claude-fixes-v2-7-57c6bd4c1655@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox