From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Add SCDC information to connector debugfs
Date: Fri, 05 Jun 2026 06:21:28 +1000 [thread overview]
Message-ID: <review-overall-20260604-scdc-link-health-v5-0-11173b0ac3de@collabora.com> (raw)
In-Reply-To: <20260604-scdc-link-health-v5-0-11173b0ac3de@collabora.com>
Overall Series Review
Subject: Add SCDC information to connector debugfs
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Patches: 5
Reviewed: 2026-06-05T06:21:28.383397
---
This v5 series adds SCDC (Status and Control Data Channel) debugfs support for HDMI connectors, exposing link health information that's useful for debugging cable/signal issues. The series is well-structured: a clean return-type fix, the core debugfs infrastructure, a bridge connector hookup, and HDMI 2.1 extensions.
The code is generally well-written and has clearly benefited from multiple review rounds. However, there are a few issues worth addressing: a **one-off error in the SCDC 256-byte read** that misses the last register, a **misplaced `drm_connector_put()` on the success path** that drops the reference before the function is done, a **missing `else` zeroing for `rs_corrections`**, and **parsed training pattern fields that are never displayed**. None are catastrophic, but the first two should be fixed before merge.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 20:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 15:52 [PATCH v5 0/4] Add SCDC information to connector debugfs Nicolas Frattaroli
2026-06-04 15:52 ` [PATCH v5 1/4] drm/scdc-helper: Don't use ssize_t return type for scdc_read/write Nicolas Frattaroli
2026-06-04 20:21 ` Claude review: " Claude Code Review Bot
2026-06-04 15:52 ` [PATCH v5 2/4] drm/scdc-helper: Add scdc_status debugfs entry Nicolas Frattaroli
2026-06-04 20:21 ` Claude review: " Claude Code Review Bot
2026-06-04 15:52 ` [PATCH v5 3/4] drm/display: bridge_connector: init scdc debugfs for HDMI Nicolas Frattaroli
2026-06-04 20:21 ` Claude review: " Claude Code Review Bot
2026-06-04 15:52 ` [PATCH v5 4/4] drm/scdc-helper: Implement parsing and printing HDMI 2.1 fields Nicolas Frattaroli
2026-06-04 20:21 ` Claude review: " Claude Code Review Bot
2026-06-04 20:21 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-27 14:03 [PATCH v4 0/4] Add SCDC information to connector debugfs Nicolas Frattaroli
2026-05-28 2:16 ` Claude review: " Claude Code Review Bot
2026-05-26 10:19 [PATCH v3 0/4] " Nicolas Frattaroli
2026-05-27 5:01 ` Claude review: " Claude Code Review Bot
2026-05-20 13:35 [PATCH v2 0/3] " Nicolas Frattaroli
2026-05-25 11:49 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260604-scdc-link-health-v5-0-11173b0ac3de@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox