From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] drm/amdgpu: deduplicate ring preempt ib function
Date: Thu, 23 Apr 2026 07:52:56 +1000 [thread overview]
Message-ID: <review-overall-59b686c6-42f5-4cde-8199-dae64722bfd1@amd.com> (raw)
In-Reply-To: <59b686c6-42f5-4cde-8199-dae64722bfd1@amd.com>
Overall Series Review
Subject: Re: [PATCH] drm/amdgpu: deduplicate ring preempt ib function
Author: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Patches: 3
Reviewed: 2026-04-23T07:52:56.153629
---
This is a straightforward and correct deduplication patch. The `ring_preempt_ib` function bodies in `gfx_v11_0.c` and `gfx_v12_0.c` are byte-for-byte identical, so extracting them into a shared `amdgpu_gfx_ring_preempt_ib()` in `amdgpu_gfx.c` is the right thing to do. The patch is clean, the logic is preserved faithfully, and the call sites are updated correctly.
There are a few minor style issues and one missed deduplication opportunity worth raising.
**Verdict: Looks good with minor nits.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 20:03 [PATCH] drm/amdgpu: deduplicate ring preempt ib function Leonardo Cesar
2026-04-22 6:58 ` Christian König
2026-04-22 12:55 ` Alex Deucher
2026-04-22 21:52 ` Claude Code Review Bot [this message]
2026-04-22 21:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-59b686c6-42f5-4cde-8199-dae64722bfd1@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox