From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] staging: fbtft: avoid empty macro argument
Date: Tue, 31 Mar 2026 17:56:51 +1000 [thread overview]
Message-ID: <review-overall-CAHp75VdGieY2qTZ_HeODxLMW8P2E3O9O27K6RRJoujxB3NZ-DA@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VdGieY2qTZ_HeODxLMW8P2E3O9O27K6RRJoujxB3NZ-DA@mail.gmail.com>
Overall Series Review
Subject: Re: [PATCH] staging: fbtft: avoid empty macro argument
Author: Andy Shevchenko <andy.shevchenko@gmail.com>
Patches: 2
Reviewed: 2026-03-31T17:56:51.241136
---
This is a single patch that replaces empty macro arguments in `define_fbtft_write_reg()` invocations with a no-op identity macro `fbtft_nop`. The change is functionally correct — the `modifier` parameter is used as `modifier(expr)` in the macro body, so passing an empty argument produces `((data_type)va_arg(...))` which works but relies on a GNU C extension (empty macro arguments are technically undefined behavior in ISO C, though widely tolerated). Replacing it with an explicit identity macro is cleaner.
However, the patch has issues that should be addressed before acceptance.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 16:01 [PATCH] staging: fbtft: avoid empty macro argument amanohina1
2026-03-28 17:49 ` Andy Shevchenko
2026-03-31 7:56 ` Claude Code Review Bot [this message]
2026-03-31 7:56 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-CAHp75VdGieY2qTZ_HeODxLMW8P2E3O9O27K6RRJoujxB3NZ-DA@mail.gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox