From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing()
Date: Tue, 31 Mar 2026 17:20:05 +1000 [thread overview]
Message-ID: <review-patch1-20260330104450.128512-2-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20260330104450.128512-2-biju.das.jz@bp.renesas.com>
Patch Review
**Purpose**: Move `rzg2l_mipi_dsi_set_display_timing()` from `atomic_pre_enable` to `atomic_enable`, placing it after `rzg2l_mipi_dsi_start_hs_clock()` per the hardware manual requirement.
**Review**:
The move itself is correct — display timings are now set after HS clock start in `atomic_enable`, which matches the hardware manual.
Minor observations:
1. **Dropped error handling on `rzg2l_mipi_dsi_startup()`**: The original code had:
```c
ret = rzg2l_mipi_dsi_startup(dsi, mode);
if (ret < 0)
return;
```
After the patch, it's simply:
```c
rzg2l_mipi_dsi_startup(dsi, mode);
```
Since `atomic_pre_enable` returns void, the old code just silently returned on error anyway (no error propagation). Dropping the check is arguably cleaner, but if `rzg2l_mipi_dsi_startup()` fails, `atomic_enable` will still proceed to call `rzg2l_mipi_dsi_start_hs_clock()` on an uninitialized PHY. Consider at minimum logging an error, or saving the error state so `atomic_enable` can bail out early. This is a pre-existing issue, not introduced by this patch.
2. **Duplicated connector/crtc/mode lookup**: The mode is looked up in both `atomic_pre_enable` and `atomic_enable` now. This is unavoidable given the bridge callback split, so it's fine, but the mode could alternatively be cached in `struct rzg2l_mipi_dsi` during `pre_enable` to avoid the repetition. Not a blocker.
3. The Fixes tags look correct, targeting the commits that introduced `atomic_pre_enable` and the original driver.
**Verdict**: Looks good. The hardware manual motivation is clear and the change is correct.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 10:44 [PATCH v3 0/3] Improvements on RZ/G2L MIPI DSI driver Biju
2026-03-30 10:44 ` [PATCH v3 1/3] drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing() Biju
2026-03-31 7:20 ` Claude Code Review Bot [this message]
2026-03-30 10:44 ` [PATCH v3 2/3] drm: renesas: rzg2l_mipi_dsi: Increase reset deassertion delay Biju
2026-03-31 7:20 ` Claude review: " Claude Code Review Bot
2026-03-30 10:44 ` [PATCH v3 3/3] drm: renesas: rzg2l_mipi_dsi: Fix deassert/assert of CMN_RSTB signal Biju
2026-03-31 7:20 ` Claude review: " Claude Code Review Bot
2026-03-31 7:20 ` Claude review: Improvements on RZ/G2L MIPI DSI driver Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 16:48 [PATCH v2 0/4] " Biju
2026-03-19 16:48 ` [PATCH v2 1/4] drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing() Biju
2026-03-21 18:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260330104450.128512-2-biju.das.jz@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox