public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rzg2l_mipi_dsi: Increase reset deassertion delay
Date: Tue, 31 Mar 2026 17:20:05 +1000	[thread overview]
Message-ID: <review-patch2-20260330104450.128512-3-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20260330104450.128512-3-biju.das.jz@bp.renesas.com>

Patch Review

**Purpose**: Replace `udelay(1)` with `fsleep(1000)` — increasing from 1 usec to 1 msec per the hardware manual requirement of >= 1 msec after CMN_RSTB deassertion.

**Review**:

This is a straightforward and clearly correct fix. The original `udelay(1)` was three orders of magnitude too short per the hardware manual.

1. **Use of `fsleep(1000)` is appropriate**: `fsleep()` automatically selects between `udelay`, `usleep_range`, and `msleep` based on the duration. For 1000 usec, it will use `usleep_range()`, which is correct for a non-atomic context (this is called from the bridge enable path, which can sleep).

2. The Fixes tag and stable Cc are appropriate — this was a real hardware requirement being violated.

**Verdict**: Clean one-liner fix. No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-31  7:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 10:44 [PATCH v3 0/3] Improvements on RZ/G2L MIPI DSI driver Biju
2026-03-30 10:44 ` [PATCH v3 1/3] drm: renesas: rzg2l_mipi_dsi: Move rzg2l_mipi_dsi_set_display_timing() Biju
2026-03-31  7:20   ` Claude review: " Claude Code Review Bot
2026-03-30 10:44 ` [PATCH v3 2/3] drm: renesas: rzg2l_mipi_dsi: Increase reset deassertion delay Biju
2026-03-31  7:20   ` Claude Code Review Bot [this message]
2026-03-30 10:44 ` [PATCH v3 3/3] drm: renesas: rzg2l_mipi_dsi: Fix deassert/assert of CMN_RSTB signal Biju
2026-03-31  7:20   ` Claude review: " Claude Code Review Bot
2026-03-31  7:20 ` Claude review: Improvements on RZ/G2L MIPI DSI driver Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260330104450.128512-3-biju.das.jz@bp.renesas.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox