From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/connector: Make drm_connector_attach_hdr_output_metadata_property() return void
Date: Tue, 31 Mar 2026 17:13:28 +1000 [thread overview]
Message-ID: <review-patch1-20260330133446.3265938-2-mcanal@igalia.com> (raw)
In-Reply-To: <20260330133446.3265938-2-mcanal@igalia.com>
Patch Review
**Reviewed-by worthy** — clean and correct.
The commit message accurately describes the change and the rationale. Two things are done here:
1. **Return type change to void**: The function body just calls `drm_object_attach_property()` (which is void) and then `return 0`. Removing the fake return value is the right thing to do. Confirmed that none of the 6 callers (amdgpu_dm, dw-hdmi, intel_dp ×2, intel_hdmi, meson_encoder_hdmi) check the return value.
2. **Typo fix**: `"HDR_OUTPUT_METADA"` → `"HDR_OUTPUT_METADATA"` in the kerneldoc — straightforward correction.
The diff is minimal and correct:
```c
-int drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector)
+void drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector)
```
The removal of the `Returns:` section from the kerneldoc and the trailing blank line + `return 0` are appropriate.
No concerns with this patch.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-31 7:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 13:33 [PATCH] drm/connector: Make drm_connector_attach_hdr_output_metadata_property() return void Maíra Canal
2026-03-30 13:54 ` Melissa Wen
2026-03-31 7:13 ` Claude review: " Claude Code Review Bot
2026-03-31 7:13 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260330133446.3265938-2-mcanal@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox