[PATCH] drm/connector: Make drm_connector_attach_hdr_output_metadata_property() return void

[PATCH] drm/connector: Make drm_connector_attach_hdr_output_metadata_property() return void

[Maíra Canal]

drm_connector_attach_hdr_output_metadata_property() always returns zero,
since drm_object_attach_property() returns void. No caller checks the
return value, so change the return type to void.

Also fix a typo in the kerneldoc ("HDR_OUTPUT_METADA" -> "HDR_OUTPUT_METADATA").

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 drivers/gpu/drm/drm_connector.c | 9 ++-------
 include/drm/drm_connector.h     | 2 +-
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 47dc53c4a738..3fa4d2082cd7 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -2867,23 +2867,18 @@ int drm_connector_attach_max_bpc_property(struct drm_connector *connector,
 EXPORT_SYMBOL(drm_connector_attach_max_bpc_property);
 
 /**
- * drm_connector_attach_hdr_output_metadata_property - attach "HDR_OUTPUT_METADA" property
+ * drm_connector_attach_hdr_output_metadata_property - attach "HDR_OUTPUT_METADATA" property
  * @connector: connector to attach the property on.
  *
  * This is used to allow the userspace to send HDR Metadata to the
  * driver.
- *
- * Returns:
- * Zero on success, negative errno on failure.
  */
-int drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector)
+void drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector)
 {
 	struct drm_device *dev = connector->dev;
 	struct drm_property *prop = dev->mode_config.hdr_output_metadata_property;
 
 	drm_object_attach_property(&connector->base, prop, 0);
-
-	return 0;
 }
 EXPORT_SYMBOL(drm_connector_attach_hdr_output_metadata_property);
 
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index af8b92d2d5b7..c8dc08773a11 100644
--- a/include/drm/drm_connector.h
+++ b/include/drm/drm_connector.h
@@ -2518,7 +2518,7 @@ int drm_connector_attach_vrr_capable_property(
 void drm_connector_attach_panel_type_property(struct drm_connector *connector);
 int drm_connector_attach_broadcast_rgb_property(struct drm_connector *connector);
 int drm_connector_attach_colorspace_property(struct drm_connector *connector);
-int drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector);
+void drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector);
 bool drm_connector_atomic_hdr_metadata_equal(struct drm_connector_state *old_state,
 					     struct drm_connector_state *new_state);
 int drm_mode_create_aspect_ratio_property(struct drm_device *dev);
-- 
2.53.0

Re: [PATCH] drm/connector: Make drm_connector_attach_hdr_output_metadata_property() return void

[Melissa Wen]

On 30/03/2026 10:33, Maíra Canal wrote:
> drm_connector_attach_hdr_output_metadata_property() always returns zero,
> since drm_object_attach_property() returns void. No caller checks the
> return value, so change the return type to void.
>
> Also fix a typo in the kerneldoc ("HDR_OUTPUT_METADA" -> "HDR_OUTPUT_METADATA").
Reviewed-by: Melissa Wen <mwen@igalia.com>
>
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>   drivers/gpu/drm/drm_connector.c | 9 ++-------
>   include/drm/drm_connector.h     | 2 +-
>   2 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index 47dc53c4a738..3fa4d2082cd7 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -2867,23 +2867,18 @@ int drm_connector_attach_max_bpc_property(struct drm_connector *connector,
>   EXPORT_SYMBOL(drm_connector_attach_max_bpc_property);
>   
>   /**
> - * drm_connector_attach_hdr_output_metadata_property - attach "HDR_OUTPUT_METADA" property
> + * drm_connector_attach_hdr_output_metadata_property - attach "HDR_OUTPUT_METADATA" property
>    * @connector: connector to attach the property on.
>    *
>    * This is used to allow the userspace to send HDR Metadata to the
>    * driver.
> - *
> - * Returns:
> - * Zero on success, negative errno on failure.
>    */
> -int drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector)
> +void drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector)
>   {
>   	struct drm_device *dev = connector->dev;
>   	struct drm_property *prop = dev->mode_config.hdr_output_metadata_property;
>   
>   	drm_object_attach_property(&connector->base, prop, 0);
> -
> -	return 0;
>   }
>   EXPORT_SYMBOL(drm_connector_attach_hdr_output_metadata_property);
>   
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index af8b92d2d5b7..c8dc08773a11 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -2518,7 +2518,7 @@ int drm_connector_attach_vrr_capable_property(
>   void drm_connector_attach_panel_type_property(struct drm_connector *connector);
>   int drm_connector_attach_broadcast_rgb_property(struct drm_connector *connector);
>   int drm_connector_attach_colorspace_property(struct drm_connector *connector);
> -int drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector);
> +void drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector);
>   bool drm_connector_atomic_hdr_metadata_equal(struct drm_connector_state *old_state,
>   					     struct drm_connector_state *new_state);
>   int drm_mode_create_aspect_ratio_property(struct drm_device *dev);

Claude review: drm/connector: Make drm_connector_attach_hdr_output_metadata_property() return void

[Claude Code Review Bot]

Overall Series Review

Subject: drm/connector: Make drm_connector_attach_hdr_output_metadata_property() return void
Author: =?UTF-8?q?Ma=C3=ADra=20Canal?= <mcanal@igalia.com>
Patches: 2
Reviewed: 2026-03-31T17:13:27.849737

---

This is a single, straightforward cleanup patch. The change is correct: `drm_connector_attach_hdr_output_metadata_property()` always returns 0 since the underlying `drm_object_attach_property()` returns void. All 6 callers in the tree already ignore the return value. The typo fix in the kerneldoc is a nice bonus. No issues found.

**Verdict: Patch looks good.**

---
Generated by Claude Code Patch Reviewer

Claude review: drm/connector: Make drm_connector_attach_hdr_output_metadata_property() return void

[Claude Code Review Bot]

Patch Review

**Reviewed-by worthy** — clean and correct.

The commit message accurately describes the change and the rationale. Two things are done here:

1. **Return type change to void**: The function body just calls `drm_object_attach_property()` (which is void) and then `return 0`. Removing the fake return value is the right thing to do. Confirmed that none of the 6 callers (amdgpu_dm, dw-hdmi, intel_dp ×2, intel_hdmi, meson_encoder_hdmi) check the return value.

2. **Typo fix**: `"HDR_OUTPUT_METADA"` → `"HDR_OUTPUT_METADATA"` in the kerneldoc — straightforward correction.

The diff is minimal and correct:

```c
-int drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector)
+void drm_connector_attach_hdr_output_metadata_property(struct drm_connector *connector)
```

The removal of the `Returns:` section from the kerneldoc and the trailing blank line + `return 0` are appropriate.

No concerns with this patch.

---
Generated by Claude Code Patch Reviewer