From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Define user readable error codes for atomic ioctl
Date: Wed, 01 Apr 2026 07:55:27 +1000 [thread overview]
Message-ID: <review-patch1-20260331-atomic-v11-1-6a1df7ec5af8@intel.com> (raw)
In-Reply-To: <20260331-atomic-v11-1-6a1df7ec5af8@intel.com>
Patch Review
**Typos in UAPI enum names (permanent ABI breakage):**
```c
DRM_MODE_ATTOMIC_CONNECTOR_BW,
DRM_MODE_ATTOMIC_PIPE_BW,
DRM_MODE_ATOMIC_SPEC_VIOLOATION,
```
These should be `DRM_MODE_ATOMIC_CONNECTOR_BW`, `DRM_MODE_ATOMIC_PIPE_BW`, and `DRM_MODE_ATOMIC_SPEC_VIOLATION`. Once merged, these misspellings are permanent UAPI.
**Typos in kernel-doc:**
```c
* @DRM_MODE_ATOMIC_INVALID_API_USAGE: invallid API usage(DRM_ATOMIC not
* enabled, invalid falg, page_flip event
```
"invallid" should be "invalid", "falg" should be "flag".
**Kernel-doc for `drm_mode_atomic_err_code`:**
```c
* @failure_code: error codes defined in enum drm_moide_atomic_failure_code
```
"drm_moide_atomic_failure_code" should be "drm_mode_atomic_failure_codes".
**Design concern with `failure_objs_ptr`:** This field is a `__u64` pointer to DRM objects, but there's no documentation on what the pointed-to data looks like. Is it an array of `__u32` object IDs? What allocates/frees this memory? None of the patches in this series actually populate it, so it's dead UAPI surface area.
**`__u64` for `failure_code`:** The enum only has 9 values. Using `__u32` would be more natural and leave the `__u64 reserved` for actual expansion. The current layout wastes space.
**`failure_string` as a fixed 128-byte char array inside a struct that gets `copy_to_user`'d:** This is 128 bytes copied on every failed atomic commit. Consider whether this is the right tradeoff vs. a userspace-provided buffer.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 21:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 9:03 [PATCH v11 0/7] User readable error codes on atomic_ioctl failure Arun R Murthy
2026-03-31 9:03 ` [PATCH v11 1/7] drm: Define user readable error codes for atomic ioctl Arun R Murthy
2026-03-31 21:55 ` Claude Code Review Bot [this message]
2026-03-31 9:03 ` [PATCH v11 2/7] drm/atomic: Add error_code element in atomic_state Arun R Murthy
2026-03-31 21:55 ` Claude review: " Claude Code Review Bot
2026-03-31 9:03 ` [PATCH v11 3/7] drm/atomic: Call complete_signaling only if prepare_signaling is done Arun R Murthy
2026-03-31 21:55 ` Claude review: " Claude Code Review Bot
2026-03-31 9:03 ` [PATCH v11 4/7] drm/atomic: Allocate atomic_state at the beginning of atomic_ioctl Arun R Murthy
2026-03-31 21:55 ` Claude review: " Claude Code Review Bot
2026-03-31 9:03 ` [PATCH v11 5/7] drm/atomic: Return user readable error in atomic_ioctl Arun R Murthy
2026-03-31 21:55 ` Claude review: " Claude Code Review Bot
2026-03-31 9:03 ` [PATCH v11 6/7] drm/i915/display: Error codes for async flip failures Arun R Murthy
2026-03-31 21:55 ` Claude review: " Claude Code Review Bot
2026-03-31 9:03 ` [PATCH v11 7/7] drm: Introduce DRM_CAP_ATOMIC_ERROR_REPORTING Arun R Murthy
2026-03-31 21:55 ` Claude review: " Claude Code Review Bot
2026-03-31 21:55 ` Claude review: User readable error codes on atomic_ioctl failure Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-02-23 9:15 [PATCH v10 0/7] " Arun R Murthy
2026-02-23 9:15 ` [PATCH v10 1/7] drm: Define user readable error codes for atomic ioctl Arun R Murthy
2026-02-24 0:26 ` Claude review: " Claude Code Review Bot
2026-02-10 9:03 [PATCH v9 0/7] User readable error codes on atomic_ioctl failure Arun R Murthy
2026-02-10 9:03 ` [PATCH v9 1/7] drm: Define user readable error codes for atomic ioctl Arun R Murthy
2026-02-11 6:31 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260331-atomic-v11-1-6a1df7ec5af8@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox