public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/atomic: Call complete_signaling only if prepare_signaling is done
Date: Wed, 01 Apr 2026 07:55:27 +1000	[thread overview]
Message-ID: <review-patch3-20260331-atomic-v11-3-6a1df7ec5af8@intel.com> (raw)
In-Reply-To: <20260331-atomic-v11-3-6a1df7ec5af8@intel.com>

Patch Review

```c
-	complete_signaling(dev, state, fence_state, num_fences, !ret);
+	if (num_fences)
+		complete_signaling(dev, state, fence_state, num_fences, !ret);
```

This is needed because patch 4 moves the state allocation earlier, so error paths now reach `out:` before `prepare_signaling` runs. The check is reasonable since `num_fences` is now initialized to 0.

However, `complete_signaling` also handles cleanup of `crtc_state->event` when `install_fds` is false (error path). Skipping it entirely when `num_fences == 0` could miss that event cleanup if we've partially set up state but never called `prepare_signaling`. Looking at the code, events are only set up inside `prepare_signaling`, so this should be safe. But a comment explaining why this is safe would help.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-31 21:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  9:03 [PATCH v11 0/7] User readable error codes on atomic_ioctl failure Arun R Murthy
2026-03-31  9:03 ` [PATCH v11 1/7] drm: Define user readable error codes for atomic ioctl Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 2/7] drm/atomic: Add error_code element in atomic_state Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 3/7] drm/atomic: Call complete_signaling only if prepare_signaling is done Arun R Murthy
2026-03-31 21:55   ` Claude Code Review Bot [this message]
2026-03-31  9:03 ` [PATCH v11 4/7] drm/atomic: Allocate atomic_state at the beginning of atomic_ioctl Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 5/7] drm/atomic: Return user readable error in atomic_ioctl Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 6/7] drm/i915/display: Error codes for async flip failures Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 7/7] drm: Introduce DRM_CAP_ATOMIC_ERROR_REPORTING Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31 21:55 ` Claude review: User readable error codes on atomic_ioctl failure Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-23  9:15 [PATCH v10 0/7] " Arun R Murthy
2026-02-23  9:16 ` [PATCH v10 3/7] drm/atomic: Call complete_signaling only if prepare_signaling is done Arun R Murthy
2026-02-24  0:26   ` Claude review: " Claude Code Review Bot
2026-02-10  9:03 [PATCH v9 0/7] User readable error codes on atomic_ioctl failure Arun R Murthy
2026-02-10  9:03 ` [PATCH v9 4/7] drm/atomic: Call complete_signaling only if prepare_signaling is done Arun R Murthy
2026-02-11  6:31   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260331-atomic-v11-3-6a1df7ec5af8@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox