public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Introduce DRM_CAP_ATOMIC_ERROR_REPORTING
Date: Wed, 01 Apr 2026 07:55:28 +1000	[thread overview]
Message-ID: <review-patch7-20260331-atomic-v11-7-6a1df7ec5af8@intel.com> (raw)
In-Reply-To: <20260331-atomic-v11-7-6a1df7ec5af8@intel.com>

Patch Review

```c
case DRM_CAP_ATOMIC_ERROR_REPORTING:
    req->value = drm_core_check_feature(dev, DRIVER_ATOMIC) && 1;
    break;
```

**`&& 1` is redundant.** `drm_core_check_feature()` already returns a boolean-like value. Just use:
```c
req->value = drm_core_check_feature(dev, DRIVER_ATOMIC);
```

**This cap is always true for all atomic drivers.** That means every atomic driver now implicitly "supports" error reporting, even though only the DRM core and i915 async flip paths actually set error codes. All other error paths will return `DRM_MODE_ATOMIC_UNSPECIFIED_ERROR` with an empty string. The capability should probably be opt-in per driver until meaningful coverage exists.

**Missing documentation:** The `DRM_CAP_ATOMIC_ERROR_REPORTING` constant should be documented alongside the description of how userspace should use the `reserved` field. There's no documentation in the UAPI header explaining the protocol: allocate `struct drm_mode_atomic_err_code`, put its address in `reserved`, call the ioctl, check the struct on failure.

---

**Summary of required fixes before merge:**
1. Fix UAPI typos (`ATTOMIC`, `VIOLOATION`, etc.) -- these are permanent
2. Fix the memory leak in `drm_mode_atomic_add_error_msg()` (missing `kfree`)
3. Add NULL check for `kvasprintf` return
4. Initialize `error_code_ptr = NULL`
5. Remove the spammy debug message when `!arg->reserved`
6. Move `copy_to_user` after the `-EDEADLK` retry logic
7. The `reserved` field repurposing needs more careful ABI design -- consider a flag bit to opt into error reporting rather than assuming non-zero `reserved` is always a valid pointer
8. Remove `&& 1` from the capability check

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-31 21:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  9:03 [PATCH v11 0/7] User readable error codes on atomic_ioctl failure Arun R Murthy
2026-03-31  9:03 ` [PATCH v11 1/7] drm: Define user readable error codes for atomic ioctl Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 2/7] drm/atomic: Add error_code element in atomic_state Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 3/7] drm/atomic: Call complete_signaling only if prepare_signaling is done Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 4/7] drm/atomic: Allocate atomic_state at the beginning of atomic_ioctl Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 5/7] drm/atomic: Return user readable error in atomic_ioctl Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 6/7] drm/i915/display: Error codes for async flip failures Arun R Murthy
2026-03-31 21:55   ` Claude review: " Claude Code Review Bot
2026-03-31  9:03 ` [PATCH v11 7/7] drm: Introduce DRM_CAP_ATOMIC_ERROR_REPORTING Arun R Murthy
2026-03-31 21:55   ` Claude Code Review Bot [this message]
2026-03-31 21:55 ` Claude review: User readable error codes on atomic_ioctl failure Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-23  9:15 [PATCH v10 0/7] " Arun R Murthy
2026-02-23  9:16 ` [PATCH v10 7/7] drm: Introduce DRM_CAP_ATOMIC_ERROR_REPORTING Arun R Murthy
2026-02-24  0:27   ` Claude review: " Claude Code Review Bot
2026-02-10  9:03 [PATCH v9 0/7] User readable error codes on atomic_ioctl failure Arun R Murthy
2026-02-10  9:04 ` [PATCH v9 7/7] drm: Introduce DRM_CAP_ATOMIC_ERROR_REPORTING Arun R Murthy
2026-02-11  6:31   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch7-20260331-atomic-v11-7-6a1df7ec5af8@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox