public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur
Date: Tue, 31 Mar 2026 16:45:30 +1000	[thread overview]
Message-ID: <review-patch1-20260331032121.1279203-1-sibi.sankar@oss.qualcomm.com> (raw)
In-Reply-To: <20260331032121.1279203-1-sibi.sankar@oss.qualcomm.com>

Patch Review

**The change:** Converts the `compatible` property schema from a flat `enum` to a `oneOf` with two alternatives:
1. The original enum (`qcom,kaanapali-fastrpc`, `qcom,fastrpc`)
2. A new fallback pattern: `qcom,glymur-fastrpc`, `qcom,kaanapali-fastrpc`

This correctly models that Glymur fastrpc is fully compatible with Kaanapali fastrpc, using the standard DT idiom of `<soc-specific>, <fallback>`.

**Minor observations:**

- The YAML schema change is correct. Using `oneOf` with a separate `items` block for the fallback compatible pair is the standard pattern in dt-bindings.

- The `items` block with a single-entry `enum` (lines 205-206):
  ```yaml
        - items:
            - enum:
                - qcom,glymur-fastrpc
            - const: qcom,kaanapali-fastrpc
  ```
  Using `enum` with a single entry works but `const: qcom,glymur-fastrpc` would be slightly more concise (matching the style used for the kaanapali fallback on the next line). This is a stylistic nit — using `enum` is also acceptable and is the preferred pattern in many bindings since it makes future additions easier without restructuring.

- The commit message is clear and the changelog is thorough.

- Has Reviewed-by from Krzysztof Kozlowski (Qualcomm DT maintainer).

**Verdict:** No issues. Patch is ready to merge.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-31  6:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  3:21 [PATCH V7] dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur Sibi Sankar
2026-03-31  6:45 ` Claude review: " Claude Code Review Bot
2026-03-31  6:45 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-13 12:08 [PATCH V5 0/5] Enable ADSP and CDSP for Glymur SoC Sibi Sankar
2026-03-13 12:08 ` [PATCH V5 3/5] dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur Sibi Sankar
2026-03-13 21:07   ` Claude review: " Claude Code Review Bot
2026-03-10  3:36 [PATCH V4 0/5] Enable ADSP and CDSP for Glymur SoC Sibi Sankar
2026-03-10  3:36 ` [PATCH V4 3/5] dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur Sibi Sankar
2026-03-11  3:43   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260331032121.1279203-1-sibi.sankar@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox