Claude review: dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur

Claude review: dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur

[Claude Code Review Bot]

Patch Review

**Looks correct.** Converts the `compatible` from a plain `enum` to `oneOf` with both the original `enum` and a new `items` variant for `qcom,glymur-fastrpc` falling back to `qcom,kaanapali-fastrpc`. This is the correct YAML pattern for adding a SoC-specific compatible that falls back to another SoC's compatible.

Minor style note: The single-item `enum` under `items` could be replaced with a `const`:
```yaml
      - items:
          - const: qcom,glymur-fastrpc
          - const: qcom,kaanapali-fastrpc
```
But the `enum` form is also fine and is commonly used when future SoC compatibles might be added to the same fallback. No change needed.

---
Generated by Claude Code Patch Reviewer

Claude review: dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur

[Claude Code Review Bot]

Patch Review

Converts the fastrpc compatible from a simple `enum` to `oneOf` to support `qcom,glymur-fastrpc` with `qcom,kaanapali-fastrpc` fallback:

```yaml
    oneOf:
      - enum:
          - qcom,kaanapali-fastrpc
          - qcom,fastrpc
      - items:
          - enum:
              - qcom,glymur-fastrpc
          - const: qcom,kaanapali-fastrpc
```

The restructuring is correct. The existing single-string compatibles are preserved in the `enum` branch, and the new two-string compatible is added as an `items` branch. Has Reviewed-by from Krzysztof Kozlowski.

**Minor observation**: The `enum` wrapping `qcom,glymur-fastrpc` is technically unnecessary when there's only one entry — a bare `const: qcom,glymur-fastrpc` would suffice. However, using `enum` is a common DT-binding convention that allows for easy future additions, so this is acceptable style.

---
Generated by Claude Code Patch Reviewer

[PATCH V7] dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur

[Sibi Sankar]

Document compatible for Qualcomm Glymur fastrpc which is fully compatible
with Qualcomm Kaanapali fastrpc.

Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---

Greg if you are still picking up patches can you please this
as well.

Changes in v7:
- Rebased on the latest Linux-next
- Split patch series so that Greg can pick this one up so that
  the dt changes can be picked up by Bjorn.
- Link to v6: https://lore.kernel.org/lkml/20260325035338.1393287-1-sibi.sankar@oss.qualcomm.com/

Changes in v6:
- Pick the audio series up. [Srini]
- Pickup Rbs from the list.
- Rebase on top of the lastest linux-next.
- Fix up address size and other misc fixes. [Konrad]
- Fix the ordering the various audio nodes. [Sibi]
- Link to v5: https://lore.kernel.org/lkml/20260313120814.1312410-1-sibi.sankar@oss.qualcomm.com/
- Link to v0 audio series: https://lore.kernel.org/lkml/20260311124230.2241781-1-srinivas.kandagatla@oss.qualcomm.com/

Changes in v5:
- Fix commit messages (patch 1/2) to accurately describe compatibility [Krzysztof]
- Link to v4: https://lore.kernel.org/lkml/20260310033617.3108675-1-sibi.sankar@oss.qualcomm.com/

Changes in v4:
- Fix SID used in ADSP/CDSP for correctness [Konrad]
- Link to v3: https://lore.kernel.org/lkml/20260129001358.770053-1-sibi.sankar@oss.qualcomm.com/

Changes in v3:
- A few variants of the SoC are expected to run Linux at EL1 hence the
  iommus properties are left optional.
- Add fastrpc bindings and nodes.
- Link to v2: https://lore.kernel.org/all/20251029-knp-remoteproc-v2-0-6c81993b52ea@oss.qualcomm.com/

Changes in v2:
- Combined into Kaanapali series since they are fully compatible.
- Link to v1: https://lore.kernel.org/all/20250924183726.509202-1-sibi.sankar@oss.qualcomm.com/

 .../devicetree/bindings/misc/qcom,fastrpc.yaml        | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
index d8e47db677cc..ca830dd06de2 100644
--- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
+++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
@@ -18,9 +18,14 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - qcom,kaanapali-fastrpc
-      - qcom,fastrpc
+    oneOf:
+      - enum:
+          - qcom,kaanapali-fastrpc
+          - qcom,fastrpc
+      - items:
+          - enum:
+              - qcom,glymur-fastrpc
+          - const: qcom,kaanapali-fastrpc
 
   label:
     enum:

base-commit: cf7c3c02fdd0dfccf4d6611714273dcb538af2cb
-- 
2.34.1

Claude review: dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur

[Claude Code Review Bot]

Overall Series Review

Subject: dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur
Author: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-03-31T16:45:30.087094

---

This is a single-patch series (v7) adding a new compatible string for the Qualcomm Glymur SoC's fastrpc binding, declaring it fully compatible with the existing Kaanapali fastrpc. The change is straightforward and follows standard dt-bindings patterns.

**Assessment: Looks good.** This is a well-understood, low-risk dt-bindings change that already has a Reviewed-by from a DT maintainer (Krzysztof Kozlowski).

---
Generated by Claude Code Patch Reviewer

Claude review: dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur

[Claude Code Review Bot]

Patch Review

**The change:** Converts the `compatible` property schema from a flat `enum` to a `oneOf` with two alternatives:
1. The original enum (`qcom,kaanapali-fastrpc`, `qcom,fastrpc`)
2. A new fallback pattern: `qcom,glymur-fastrpc`, `qcom,kaanapali-fastrpc`

This correctly models that Glymur fastrpc is fully compatible with Kaanapali fastrpc, using the standard DT idiom of `<soc-specific>, <fallback>`.

**Minor observations:**

- The YAML schema change is correct. Using `oneOf` with a separate `items` block for the fallback compatible pair is the standard pattern in dt-bindings.

- The `items` block with a single-entry `enum` (lines 205-206):
  ```yaml
        - items:
            - enum:
                - qcom,glymur-fastrpc
            - const: qcom,kaanapali-fastrpc
  ```
  Using `enum` with a single entry works but `const: qcom,glymur-fastrpc` would be slightly more concise (matching the style used for the kaanapali fallback on the next line). This is a stylistic nit — using `enum` is also acceptable and is the preferred pattern in many bindings since it makes future additions easier without restructuring.

- The commit message is clear and the changelog is thorough.

- Has Reviewed-by from Krzysztof Kozlowski (Qualcomm DT maintainer).

**Verdict:** No issues. Patch is ready to merge.

---
Generated by Claude Code Patch Reviewer