public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ivpu: Fix swapped register names in pwr_island_drive functions
Date: Thu, 23 Apr 2026 08:38:04 +1000	[thread overview]
Message-ID: <review-patch1-20260421093907.37304-1-karol.wachowski@linux.intel.com> (raw)
In-Reply-To: <20260421093907.37304-1-karol.wachowski@linux.intel.com>

Patch Review

**Assessment: Correct, no issues.**

The fix is a clean symmetric swap. In `pwr_island_drive_37xx`:
```c
-	u32 val = REGV_RD32(VPU_40XX_HOST_SS_AON_PWR_ISLAND_EN0);
+	u32 val = REGV_RD32(VPU_37XX_HOST_SS_AON_PWR_ISLAND_EN0);
```
and the field name changes from `CSS_CPU` to `MSS_CPU` (matching the 37xx header definition). In `pwr_island_drive_40xx`, the inverse swap is applied.

I verified in the register definition headers:
- `ivpu_hw_37xx_reg.h:98`: `VPU_37XX_HOST_SS_AON_PWR_ISLAND_EN0 = 0x00030024u` with `MSS_CPU_MASK = BIT_MASK(3)`
- `ivpu_hw_40xx_reg.h:107`: `VPU_40XX_HOST_SS_AON_PWR_ISLAND_EN0 = 0x00030024u` with `CSS_CPU_MASK = BIT_MASK(3)`

The `REG_SET_FLD` / `REG_CLR_FLD` macros in `ivpu_hw_reg_io.h` concatenate `REG##_##FLD##_MASK` to form the mask name, so the register name and field name must be from the same generation's header. Before this patch they happened to work only because the offsets and bit positions are identical across generations.

**Minor notes:**
- The commit message could mention a `Fixes:` tag pointing to the commit that introduced the bug, which helps stable-tree backport tracking. However, since the bug is cosmetic, this is not strictly necessary.
- No functional change — safe to apply as-is.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-22 22:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21  9:39 [PATCH] accel/ivpu: Fix swapped register names in pwr_island_drive functions Karol Wachowski
2026-04-22 22:38 ` Claude review: " Claude Code Review Bot
2026-04-22 22:38 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260421093907.37304-1-karol.wachowski@linux.intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox