From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ivpu: Fix swapped register names in pwr_island_drive functions
Date: Thu, 23 Apr 2026 08:38:04 +1000 [thread overview]
Message-ID: <review-overall-20260421093907.37304-1-karol.wachowski@linux.intel.com> (raw)
In-Reply-To: <20260421093907.37304-1-karol.wachowski@linux.intel.com>
Overall Series Review
Subject: accel/ivpu: Fix swapped register names in pwr_island_drive functions
Author: Karol Wachowski <karol.wachowski@linux.intel.com>
Patches: 1
Reviewed: 2026-04-23T08:38:04.112852
---
This is a single-patch fix for the Intel VPU (NPU) accelerator driver (`accel/ivpu`). The patch swaps register name definitions that were incorrectly used in the wrong hardware-generation-specific functions: `pwr_island_drive_37xx` was using `VPU_40XX_*` register names, and `pwr_island_drive_40xx` was using `VPU_37XX_*` register names.
As the commit message correctly states, this is a **purely cosmetic fix** — both register names resolve to the same offset (`0x00030024u`) and both field masks (`MSS_CPU` for 37xx, `CSS_CPU` for 40xx) resolve to `BIT_MASK(3)`. The generated code is binary-identical before and after this patch. The fix improves code correctness and readability by ensuring each function uses the register definitions matching its hardware generation.
**Verdict**: Straightforward and correct. No functional risk.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 9:39 [PATCH] accel/ivpu: Fix swapped register names in pwr_island_drive functions Karol Wachowski
2026-04-22 22:38 ` Claude Code Review Bot [this message]
2026-04-22 22:38 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260421093907.37304-1-karol.wachowski@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox