From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: adv7511: Clear HPD IRQ during atomic_enable()
Date: Thu, 23 Apr 2026 07:43:34 +1000 [thread overview]
Message-ID: <review-patch1-20260422121457.166780-1-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20260422121457.166780-1-biju.das.jz@bp.renesas.com>
Patch Review
**Correctness**: The fix is sound. The `ADV7511_REG_INT(0)` register (address 0x96) uses write-1-to-clear semantics — writing `ADV7511_INT0_HPD` (BIT(7)) clears only the HPD status bit without affecting other interrupt status bits. This is consistent with how the driver already clears interrupts in `adv7511_irq_process()`:
```c
regmap_write(adv7511->regmap, ADV7511_REG_INT(0), irq0);
regmap_write(adv7511->regmap, ADV7511_REG_INT(1), irq1);
```
and in `adv7511_hpd()`:
```c
regmap_write(adv7511->regmap, ADV7511_REG_INT(0), ADV7511_INT0_HPD);
```
**Placement**: Correct. The clear happens after `adv7511_power_on()`, which powers up the chip and re-enables interrupt generation via `ADV7511_REG_INT_ENABLE(0)`, but does not itself clear any pending status bits. Clearing after power-on ensures the chip is responsive to the register write.
**Scope**: The patch clears only the HPD bit, not other potential stale interrupt bits (EDID_READY, DDC_ERROR, etc.). This is reasonable — HPD is the one specifically reported as causing problems. If other stale interrupts turn out to be an issue, a follow-up could clear all of INT(0) and INT(1), but there's no reason to over-broaden the fix now.
**Minor observation**: The comment is slightly verbose at 4 lines for what is a single write-1-to-clear operation, but it does explain the *why* (stale state across power loss), which is the right kind of comment to include since the reason isn't obvious from the code alone.
**No issues found.** The patch is a clean, minimal, well-targeted fix.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:14 [PATCH v2] drm/bridge: adv7511: Clear HPD IRQ during atomic_enable() Biju
2026-04-22 13:34 ` Tommaso Merciai
2026-04-22 21:43 ` Claude Code Review Bot [this message]
2026-04-22 21:43 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260422121457.166780-1-biju.das.jz@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox