public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: backlight: cgbc: Remove redundant X86 dependency
Date: Tue, 28 Apr 2026 14:50:33 +1000	[thread overview]
Message-ID: <review-patch1-20260427-backlight-cgbc-remove-x86-dependency-v2-1-da9f2375a34a@bootlin.com> (raw)
In-Reply-To: <20260427-backlight-cgbc-remove-x86-dependency-v2-1-da9f2375a34a@bootlin.com>

Patch Review

**Verdict: Good to go.**

The change removes `&& X86` from the `BACKLIGHT_CGBC` Kconfig entry:

```
-	depends on MFD_CGBC && X86
+	depends on MFD_CGBC
```

This is correct. `MFD_CGBC` is defined in `drivers/mfd/Kconfig:241-244` as:

```
config MFD_CGBC
	tristate "Congatec Board Controller"
	select MFD_CORE
	depends on X86
```

Since `MFD_CGBC` already depends on `X86`, any symbol that `depends on MFD_CGBC` transitively inherits the X86 constraint — the explicit `X86` in the backlight Kconfig was redundant. This is consistent with how the other CGBC sub-drivers (watchdog, gpio, hwmon, i2c) are already written — none of them add an explicit `X86` dependency alongside `MFD_CGBC`.

One minor observation: the help text still says "x86-based boards", which is fine — it's describing the hardware, not a Kconfig constraint.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-28  4:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27  9:40 [PATCH v2 0/2] Remove redundant X86 dependency for the cgbc backlight driver Thomas Richard
2026-04-27  9:40 ` [PATCH v2 1/2] backlight: cgbc: Remove redundant X86 dependency Thomas Richard
2026-04-28  4:50   ` Claude Code Review Bot [this message]
2026-04-27  9:40 ` [PATCH v2 2/2] MAINTAINERS: Add cgbc backlight driver Thomas Richard
2026-04-28  4:50   ` Claude review: " Claude Code Review Bot
2026-04-28  4:50 ` Claude review: Remove redundant X86 dependency for the " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260427-backlight-cgbc-remove-x86-dependency-v2-1-da9f2375a34a@bootlin.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox