[PATCH v2 0/2] Remove redundant X86 dependency for the cgbc backlight driver

[PATCH v2 0/2] Remove redundant X86 dependency for the cgbc backlight driver

[Thomas Richard]

For this second iteration, I just added Daniel's RB tags.

Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
Changes in v2:
- add Daniel's RB tags.
- Link to v1: https://lore.kernel.org/r/20260327-backlight-cgbc-remove-x86-dependency-v1-0-4851c9e95371@bootlin.com

---
Thomas Richard (2):
      backlight: cgbc: Remove redundant X86 dependency
      MAINTAINERS: Add cgbc backlight driver

 MAINTAINERS                     | 1 +
 drivers/video/backlight/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
---
base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
change-id: 20260309-backlight-cgbc-remove-x86-dependency-40a7c9516459

Best regards,
-- 
Thomas Richard <thomas.richard@bootlin.com>

[PATCH v2 1/2] backlight: cgbc: Remove redundant X86 dependency

[Thomas Richard]

The backlight driver depends on the MFD cgbc-core driver, which already
depends on X86. The explicit X86 dependency for the backlight driver is
redundant and can be safely removed.

Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
 drivers/video/backlight/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index a7a3fbaf7c29..07905d2ba01a 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -260,7 +260,7 @@ config BACKLIGHT_PWM
 
 config BACKLIGHT_CGBC
 	tristate "Congatec Board Controller (CGBC) backlight support"
-	depends on MFD_CGBC && X86
+	depends on MFD_CGBC
 	help
 	  Say Y here to enable support for LCD backlight control on Congatec
 	  x86-based boards via the CGBC (Congatec Board Controller).

-- 
2.53.0

[PATCH v2 2/2] MAINTAINERS: Add cgbc backlight driver

[Thomas Richard]

Add missing backlight driver in CONGATEC BOARD CONTROLLER entry.

Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2fb1c75afd16..15b8db0721ea 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6474,6 +6474,7 @@ F:	drivers/gpio/gpio-cgbc.c
 F:	drivers/hwmon/cgbc-hwmon.c
 F:	drivers/i2c/busses/i2c-cgbc.c
 F:	drivers/mfd/cgbc-core.c
+F:	drivers/video/backlight/cgbc_bl.c
 F:	drivers/watchdog/cgbc_wdt.c
 F:	include/linux/mfd/cgbc.h
 

-- 
2.53.0

Claude review: Remove redundant X86 dependency for the cgbc backlight driver

[Claude Code Review Bot]

Overall Series Review

Subject: Remove redundant X86 dependency for the cgbc backlight driver
Author: Thomas Richard <thomas.richard@bootlin.com>
Patches: 3
Reviewed: 2026-04-28T14:50:33.339163

---

This is a clean, straightforward 2-patch series. Patch 1 removes a redundant `X86` Kconfig dependency from the CGBC backlight driver since the parent MFD driver (`MFD_CGBC`) already `depends on X86` (confirmed at `drivers/mfd/Kconfig:244`). Patch 2 adds the backlight driver file to the MAINTAINERS entry. Both patches already carry Daniel Thompson's Reviewed-by tag from v1. The series is correct and ready to merge.

**No issues found.**

---
Generated by Claude Code Patch Reviewer

Claude review: backlight: cgbc: Remove redundant X86 dependency

[Claude Code Review Bot]

Patch Review

**Verdict: Good to go.**

The change removes `&& X86` from the `BACKLIGHT_CGBC` Kconfig entry:

```
-	depends on MFD_CGBC && X86
+	depends on MFD_CGBC
```

This is correct. `MFD_CGBC` is defined in `drivers/mfd/Kconfig:241-244` as:

```
config MFD_CGBC
	tristate "Congatec Board Controller"
	select MFD_CORE
	depends on X86
```

Since `MFD_CGBC` already depends on `X86`, any symbol that `depends on MFD_CGBC` transitively inherits the X86 constraint — the explicit `X86` in the backlight Kconfig was redundant. This is consistent with how the other CGBC sub-drivers (watchdog, gpio, hwmon, i2c) are already written — none of them add an explicit `X86` dependency alongside `MFD_CGBC`.

One minor observation: the help text still says "x86-based boards", which is fine — it's describing the hardware, not a Kconfig constraint.

---
Generated by Claude Code Patch Reviewer

Claude review: MAINTAINERS: Add cgbc backlight driver

[Claude Code Review Bot]

Patch Review

**Verdict: Good to go.**

Adds the missing file entry to the CONGATEC BOARD CONTROLLER section:

```
+F:	drivers/video/backlight/cgbc_bl.c
```

The entry is inserted in alphabetical order between `drivers/mfd/cgbc-core.c` and `drivers/watchdog/cgbc_wdt.c`, which is correct. The file path matches the actual driver source. This was simply an oversight when the backlight driver was originally added — it should have been in MAINTAINERS from the start.

---
Generated by Claude Code Patch Reviewer