From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: Export mem_accounting parameter
Date: Tue, 28 Apr 2026 14:45:01 +1000 [thread overview]
Message-ID: <review-patch1-20260427-dma-buf-heaps-as-modules-v5-1-b6f5678feefc@kernel.org> (raw)
In-Reply-To: <20260427-dma-buf-heaps-as-modules-v5-1-b6f5678feefc@kernel.org>
Patch Review
**Change:** Adds `EXPORT_SYMBOL_NS_GPL(mem_accounting, "DMA_BUF_HEAP")` after the existing `module_param` declaration in `drivers/dma-buf/dma-heap.c`.
This is correct and necessary. The `mem_accounting` variable is declared `extern` in `include/linux/dma-heap.h:49` and is used by `system_heap.c:388`. Without this export, building `system_heap.c` as a module would fail at link time. Using `_NS_GPL` with the `"DMA_BUF_HEAP"` namespace is consistent with the existing export namespace for the dma-buf heap APIs.
Note that `cma_heap.c` does not currently reference `mem_accounting`, so this export is strictly needed only for the system heap (patch 3), not the CMA heap (patch 2). The ordering is still correct since patch 1 logically prepares the infrastructure for both module conversions.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 4:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 10:04 [PATCH v5 0/4] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-04-27 10:04 ` [PATCH v5 1/4] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-04-28 4:45 ` Claude Code Review Bot [this message]
2026-04-27 10:04 ` [PATCH v5 2/4] dma-buf: heaps: cma: Turn the heap into a module Maxime Ripard
2026-04-28 4:45 ` Claude review: " Claude Code Review Bot
2026-04-27 10:04 ` [PATCH v5 3/4] dma-buf: heaps: system: " Maxime Ripard
2026-04-28 4:45 ` Claude review: " Claude Code Review Bot
2026-04-27 10:05 ` [PATCH v5 4/4] arm64: defconfig: Enable dma-buf heaps Maxime Ripard
2026-04-28 4:45 ` Claude review: " Claude Code Review Bot
2026-04-28 4:45 ` Claude review: dma-buf: heaps: Turn heaps into modules Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-31 10:00 [PATCH v4 0/8] " Maxime Ripard
2026-03-31 10:00 ` [PATCH v4 6/8] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-03 10:13 [PATCH v3 0/8] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-03-03 10:13 ` [PATCH v3 6/8] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 [PATCH 0/7] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-02-25 16:41 ` [PATCH 5/7] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260427-dma-buf-heaps-as-modules-v5-1-b6f5678feefc@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox