From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: system: Turn the heap into a module
Date: Tue, 28 Apr 2026 14:45:01 +1000 [thread overview]
Message-ID: <review-patch3-20260427-dma-buf-heaps-as-modules-v5-3-b6f5678feefc@kernel.org> (raw)
In-Reply-To: <20260427-dma-buf-heaps-as-modules-v5-3-b6f5678feefc@kernel.org>
Patch Review
**Change:**
- `drivers/dma-buf/heaps/Kconfig`: `DMABUF_HEAPS_SYSTEM` changed from `bool` to `tristate`
- `drivers/dma-buf/heaps/system_heap.c`: Adds `MODULE_DESCRIPTION("DMA-BUF System Heap")`, `MODULE_LICENSE("GPL")`, `MODULE_IMPORT_NS("DMA_BUF")`, `MODULE_IMPORT_NS("DMA_BUF_HEAP")`
Same pattern as the CMA heap patch. This one also adds `MODULE_DESCRIPTION` which the CMA heap already had from a prior commit. The namespace imports are correct — this heap directly uses `mem_accounting` (at line 388), so the `DMA_BUF_HEAP` import is needed.
Same no-`module_exit` situation applies here, correctly documented.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 4:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 10:04 [PATCH v5 0/4] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-04-27 10:04 ` [PATCH v5 1/4] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-04-28 4:45 ` Claude review: " Claude Code Review Bot
2026-04-27 10:04 ` [PATCH v5 2/4] dma-buf: heaps: cma: Turn the heap into a module Maxime Ripard
2026-04-28 4:45 ` Claude review: " Claude Code Review Bot
2026-04-27 10:04 ` [PATCH v5 3/4] dma-buf: heaps: system: " Maxime Ripard
2026-04-28 4:45 ` Claude Code Review Bot [this message]
2026-04-27 10:05 ` [PATCH v5 4/4] arm64: defconfig: Enable dma-buf heaps Maxime Ripard
2026-04-28 4:45 ` Claude review: " Claude Code Review Bot
2026-04-28 4:45 ` Claude review: dma-buf: heaps: Turn heaps into modules Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-31 10:00 [PATCH v4 0/8] " Maxime Ripard
2026-03-31 10:00 ` [PATCH v4 8/8] dma-buf: heaps: system: Turn the heap into a module Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-03 10:13 [PATCH v3 0/8] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-03-03 10:13 ` [PATCH v3 8/8] dma-buf: heaps: system: Turn the heap into a module Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 [PATCH 0/7] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-02-25 16:41 ` [PATCH 7/7] dma-buf: heaps: system: Turn the heap into a module Maxime Ripard
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260427-dma-buf-heaps-as-modules-v5-3-b6f5678feefc@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox