From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: system: Turn the heap into a module
Date: Wed, 01 Apr 2026 07:50:37 +1000 [thread overview]
Message-ID: <review-patch8-20260331-dma-buf-heaps-as-modules-v4-8-e18fda504419@kernel.org> (raw)
In-Reply-To: <20260331-dma-buf-heaps-as-modules-v4-8-e18fda504419@kernel.org>
Patch Review
Same pattern as patch 7 for the system heap. Changes to tristate, adds MODULE macros.
```c
MODULE_DESCRIPTION("DMA-BUF System Heap");
MODULE_LICENSE("GPL");
MODULE_IMPORT_NS("DMA_BUF");
MODULE_IMPORT_NS("DMA_BUF_HEAP");
```
Same no-unload caveat as the CMA heap.
No issues.
---
**Summary:** The series is clean, well-organized, and achieves its goal with minimal changes. The only substantive concern is the potential for duplicate heap creation when the default CMA area is both in the `dma_contiguous_areas[]` list and handled separately by `add_cma_heaps()`, but this appears to be pre-existing behavior. The series is in good shape for merging.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 21:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260331100026eucas1p19bdc2aaca4c9a48c6f6ac8fec71478d8@eucas1p1.samsung.com>
2026-03-31 10:00 ` [PATCH v4 0/8] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-03-31 10:00 ` [PATCH v4 1/8] dma: contiguous: Turn heap registration logic around Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 2/8] dma: contiguous: Make dev_get_cma_area() a proper function Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 3/8] dma: contiguous: Make dma_contiguous_default_area static Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 4/8] dma: contiguous: Export dev_get_cma_area() Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 5/8] mm: cma: Export cma_alloc(), cma_release() and cma_get_name() Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 6/8] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 7/8] dma-buf: heaps: cma: Turn the heap into a module Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 8/8] dma-buf: heaps: system: " Maxime Ripard
2026-03-31 21:50 ` Claude Code Review Bot [this message]
2026-03-31 12:54 ` [PATCH v4 0/8] dma-buf: heaps: Turn heaps into modules Marek Szyprowski
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-03 10:13 [PATCH v3 0/8] " Maxime Ripard
2026-03-03 10:13 ` [PATCH v3 8/8] dma-buf: heaps: system: Turn the heap into a module Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-02-25 16:41 [PATCH 0/7] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-02-25 16:41 ` [PATCH 7/7] dma-buf: heaps: system: Turn the heap into a module Maxime Ripard
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch8-20260331-dma-buf-heaps-as-modules-v4-8-e18fda504419@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox