From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: cma: Turn the heap into a module
Date: Wed, 01 Apr 2026 07:50:37 +1000 [thread overview]
Message-ID: <review-patch7-20260331-dma-buf-heaps-as-modules-v4-7-e18fda504419@kernel.org> (raw)
In-Reply-To: <20260331-dma-buf-heaps-as-modules-v4-7-e18fda504419@kernel.org>
Patch Review
Changes `DMABUF_HEAPS_CMA` from `bool` to `tristate`, adds `MODULE_LICENSE("GPL")`, and imports `DMA_BUF` and `DMA_BUF_HEAP` namespaces.
The patch also changes `__init` to `module_init` -- wait, looking again, the function `add_cma_heaps` was already using `module_init()` macro in the existing code (`module_init(add_cma_heaps)`). But the function is still declared `static int __init add_cma_heaps(void)`. When built as a module, `__init` becomes a section annotation that is fine for module init functions, so this is correct.
**No module_exit:** The commit message explicitly states "This heap won't be able to unload though, since we're missing a lot of infrastructure to make it safe." This is acceptable for now -- modules without `module_exit` cannot be unloaded. However, this means `rmmod` will fail with `EBUSY` or similar. This is a deliberate design choice documented in the commit message.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 21:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260331100026eucas1p19bdc2aaca4c9a48c6f6ac8fec71478d8@eucas1p1.samsung.com>
2026-03-31 10:00 ` [PATCH v4 0/8] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-03-31 10:00 ` [PATCH v4 1/8] dma: contiguous: Turn heap registration logic around Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 2/8] dma: contiguous: Make dev_get_cma_area() a proper function Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 3/8] dma: contiguous: Make dma_contiguous_default_area static Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 4/8] dma: contiguous: Export dev_get_cma_area() Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 5/8] mm: cma: Export cma_alloc(), cma_release() and cma_get_name() Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 6/8] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 10:00 ` [PATCH v4 7/8] dma-buf: heaps: cma: Turn the heap into a module Maxime Ripard
2026-03-31 21:50 ` Claude Code Review Bot [this message]
2026-03-31 10:00 ` [PATCH v4 8/8] dma-buf: heaps: system: " Maxime Ripard
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-31 12:54 ` [PATCH v4 0/8] dma-buf: heaps: Turn heaps into modules Marek Szyprowski
2026-03-31 21:50 ` Claude review: " Claude Code Review Bot
2026-03-03 10:13 [PATCH v3 0/8] " Maxime Ripard
2026-03-03 10:13 ` [PATCH v3 7/8] dma-buf: heaps: cma: Turn the heap into a module Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-02-25 16:41 [PATCH 0/7] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-02-25 16:41 ` [PATCH 6/7] dma-buf: heaps: cma: Turn the heap into a module Maxime Ripard
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch7-20260331-dma-buf-heaps-as-modules-v4-7-e18fda504419@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox