public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: visionox-rm69299: Split DSI commands out into enable/disable
Date: Tue, 28 Apr 2026 14:33:55 +1000	[thread overview]
Message-ID: <review-patch1-20260427-visionox-rm69299-enable-v1-1-fa7d62d26d87@sigxcpu.org> (raw)
In-Reply-To: <20260427-visionox-rm69299-enable-v1-1-fa7d62d26d87@sigxcpu.org>

Patch Review

This is the substantive fix. The init sequence, `exit_sleep_mode`, `set_display_on` move from `prepare` to a new `enable` callback, and `set_display_off`, `enter_sleep_mode` move from `unprepare` to a new `disable` callback. The remaining `prepare`/`unprepare` become thin wrappers around `power_on`/`power_off`.

The code motion is faithful — no logic changes, same delays, same LPM flag manipulation. The fix is correct: DSI commands must be sent after the video pipeline is up (`enable`) and before it goes down (`disable`), not during power sequencing.

One minor style observation on the funcs struct:

```c
static const struct drm_panel_funcs visionox_rm69299_drm_funcs = {
	.unprepare = visionox_rm69299_unprepare,
	.disable   = visionox_rm69299_disable,
	.prepare   = visionox_rm69299_prepare,
	.enable	   = visionox_rm69299_enable,
	.get_modes = visionox_rm69299_get_modes,
};
```

The alignment with extra spaces (`.disable   =`, `.prepare   =`) is inconsistent with the rest of the file and not standard kernel style. Tabs-only alignment or no padding would be more conventional. Very minor.

No functional issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-28  4:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 13:56 [PATCH 0/2] drm/panel/visionox-rm69299: Split DSI commands out into enable/disable Guido Günther
2026-04-27 13:56 ` [PATCH 1/2] drm/panel: visionox-rm69299: " Guido Günther
2026-04-28  4:33   ` Claude Code Review Bot [this message]
2026-04-27 13:56 ` [PATCH 2/2] drm/panel: visionox-rm69299: Move power_on/off into prepare/unprepare Guido Günther
2026-04-28  4:33   ` Claude review: " Claude Code Review Bot
2026-04-28  4:33 ` Claude review: drm/panel/visionox-rm69299: Split DSI commands out into enable/disable Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260427-visionox-rm69299-enable-v1-1-fa7d62d26d87@sigxcpu.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox