public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: visionox-rm69299: Move power_on/off into prepare/unprepare
Date: Tue, 28 Apr 2026 14:33:55 +1000	[thread overview]
Message-ID: <review-patch2-20260427-visionox-rm69299-enable-v1-2-fa7d62d26d87@sigxcpu.org> (raw)
In-Reply-To: <20260427-visionox-rm69299-enable-v1-2-fa7d62d26d87@sigxcpu.org>

Patch Review

A clean simplification. After patch 1, `prepare` just called `power_on` and `unprepare` just called `power_off`, so inlining them is the right call.

One minor reverse-christmas-tree nit in the new `prepare`:

```c
static int visionox_rm69299_prepare(struct drm_panel *panel)
{
	int ret;
	struct visionox_rm69299 *ctx = panel_to_ctx(panel);
```

Kernel convention puts longer declarations first. This should be:

```c
	struct visionox_rm69299 *ctx = panel_to_ctx(panel);
	int ret;
```

Also, the diff removes a blank line between the error check and the subsequent block comment:

```c
	if (ret < 0)
		return ret;
	/*
	 * Reset sequence of visionox panel requires the panel to be
```

The original had a blank line separating those, which aided readability. Very minor.

No functional issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-28  4:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 13:56 [PATCH 0/2] drm/panel/visionox-rm69299: Split DSI commands out into enable/disable Guido Günther
2026-04-27 13:56 ` [PATCH 1/2] drm/panel: visionox-rm69299: " Guido Günther
2026-04-28  4:33   ` Claude review: " Claude Code Review Bot
2026-04-27 13:56 ` [PATCH 2/2] drm/panel: visionox-rm69299: Move power_on/off into prepare/unprepare Guido Günther
2026-04-28  4:33   ` Claude Code Review Bot [this message]
2026-04-28  4:33 ` Claude review: drm/panel/visionox-rm69299: Split DSI commands out into enable/disable Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260427-visionox-rm69299-enable-v1-2-fa7d62d26d87@sigxcpu.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox