From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display/msm: gpu: Document Adreno X2-185
Date: Tue, 05 May 2026 09:19:36 +1000 [thread overview]
Message-ID: <review-patch1-20260501-glymur-gpu-dt-v2-1-2f128b5596bb@oss.qualcomm.com> (raw)
In-Reply-To: <20260501-glymur-gpu-dt-v2-1-2f128b5596bb@oss.qualcomm.com>
Patch Review
**Status: Looks good.**
This patch adds a single compatible string entry:
```
- qcom,adreno-43051401
+ - qcom,adreno-44070001
```
The compatible string `qcom,adreno-44070001` follows the established naming convention of `qcom,adreno-XXYYYZZZ` where the hex value encodes the chip/core/major/minor IDs. It is placed in sorted order after the existing A430 family entries.
One minor note: the commit message says "Adreno X2-185" but the cover letter says "Adreno X2-85". The subject line also says "X2-185". It would be good to confirm which marketing name is correct — the cover letter and the commit messages disagree. If the cover letter's "X2-85" is the correct name, the commit message subject should be updated.
No other concerns.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 23:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 17:10 [PATCH v2 0/4] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-01 17:10 ` [PATCH v2 1/4] dt-bindings: display/msm: gpu: Document Adreno X2-185 Akhil P Oommen
2026-05-03 14:10 ` Krzysztof Kozlowski
2026-05-03 14:13 ` Krzysztof Kozlowski
2026-05-04 23:19 ` Claude Code Review Bot [this message]
2026-05-01 17:10 ` [PATCH v2 2/4] dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU Akhil P Oommen
2026-05-03 14:14 ` Krzysztof Kozlowski
2026-05-04 23:19 ` Claude review: " Claude Code Review Bot
2026-05-01 17:10 ` [PATCH v2 3/4] arm64: dts: qcom: glymur: Add GPU smmu node Akhil P Oommen
2026-05-04 23:19 ` Claude review: " Claude Code Review Bot
2026-05-01 17:10 ` [PATCH v2 4/4] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-04 23:19 ` Claude review: " Claude Code Review Bot
2026-05-04 23:19 ` Claude review: Devicetree support for Glymur GPU Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260501-glymur-gpu-dt-v2-1-2f128b5596bb@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox