public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU
Date: Tue, 05 May 2026 09:19:36 +1000	[thread overview]
Message-ID: <review-patch2-20260501-glymur-gpu-dt-v2-2-2f128b5596bb@oss.qualcomm.com> (raw)
In-Reply-To: <20260501-glymur-gpu-dt-v2-2-2f128b5596bb@oss.qualcomm.com>

Patch Review

**Status: Minor observations.**

This patch does two things:

1. Adds an `interconnects` property to the common SMMU properties:

```
+  interconnects:
+    maxItems: 1
```

2. Extends the SM8750-specific compatible section to also cover Glymur:

```
-            - const: qcom,sm8750-smmu-500
+            - enum:
+                - qcom,glymur-smmu-500
+                - qcom,sm8750-smmu-500
```

**Observations:**

- The `interconnects` addition at the top-level of the SMMU schema is a global change — it allows `interconnects` for *all* ARM SMMU variants, not just the Glymur one. Looking at the existing kernel tree, no current `adreno_smmu` node (sm8550, sm8650) uses `interconnects`. This is presumably a new requirement for Glymur. The DT binding maintainers may want to confirm whether this should be constrained to specific compatible strings rather than being globally allowed. That said, `maxItems: 1` is reasonable and the property is well-understood in the DT ecosystem.

- The sm8750 section reuse is sensible since Glymur and SM8750 share the same GPU SMMU clock configuration (single "hlos" clock).

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-04 23:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 17:10 [PATCH v2 0/4] Devicetree support for Glymur GPU Akhil P Oommen
2026-05-01 17:10 ` [PATCH v2 1/4] dt-bindings: display/msm: gpu: Document Adreno X2-185 Akhil P Oommen
2026-05-03 14:10   ` Krzysztof Kozlowski
2026-05-03 14:13     ` Krzysztof Kozlowski
2026-05-04 23:19   ` Claude review: " Claude Code Review Bot
2026-05-01 17:10 ` [PATCH v2 2/4] dt-bindings: arm-smmu: Update the description for Glymur GPU SMMU Akhil P Oommen
2026-05-03 14:14   ` Krzysztof Kozlowski
2026-05-04 23:19   ` Claude Code Review Bot [this message]
2026-05-01 17:10 ` [PATCH v2 3/4] arm64: dts: qcom: glymur: Add GPU smmu node Akhil P Oommen
2026-05-04 23:19   ` Claude review: " Claude Code Review Bot
2026-05-01 17:10 ` [PATCH v2 4/4] arm64: dts: qcom: Add GPU support for Glymur Akhil P Oommen
2026-05-04 23:19   ` Claude review: " Claude Code Review Bot
2026-05-04 23:19 ` Claude review: Devicetree support for Glymur GPU Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260501-glymur-gpu-dt-v2-2-2f128b5596bb@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox