From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/nouveau/kms/nvd9-: Remove unused header in crc.c
Date: Tue, 05 May 2026 09:07:11 +1000 [thread overview]
Message-ID: <review-patch1-20260501215703.820656-2-lyude@redhat.com> (raw)
In-Reply-To: <20260501215703.820656-2-lyude@redhat.com>
Patch Review
**Status: Clean**
The patch removes the unused include:
```c
-#include "wndw.h"
```
I verified that `crc.c` contains zero references to any symbol exported by `wndw.h` — no use of `struct nv50_wndw`, `struct nv50_wndw_func`, `nv50_wndw()`, or any of the `wndwc*` / `base507c*` function declarations. The remaining includes (`nouveau_drv.h`, `core.h`, `head.h`, `handles.h`, `crc.h`) are sufficient for everything `crc.c` needs.
**Minor nit on the subject line:** The subject says "nvd9-" (suggesting GF119+), but the file path is `dispnv50/` which covers NV50 and later. The "nvd9-" scope qualifier in the subject seems to refer to the CRC feature's hardware support range rather than the file location, which is fine, but could be slightly confusing since the file itself is shared across the dispnv50 code.
**No issues found.** Reviewed-by worthy as-is.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-04 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 21:57 [PATCH] drm/nouveau/kms/nvd9-: Remove unused header in crc.c Lyude Paul
2026-05-04 23:07 ` Claude review: " Claude Code Review Bot
2026-05-04 23:07 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260501215703.820656-2-lyude@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox