* [PATCH] drm/nouveau/kms/nvd9-: Remove unused header in crc.c
@ 2026-05-01 21:57 Lyude Paul
2026-05-04 23:07 ` Claude review: " Claude Code Review Bot
2026-05-04 23:07 ` Claude Code Review Bot
0 siblings, 2 replies; 3+ messages in thread
From: Lyude Paul @ 2026-05-01 21:57 UTC (permalink / raw)
To: dri-devel, nouveau, linux-kernel
Cc: Timur Tabi, Dave Airlie, Maarten Lankhorst, Ben Skeggs,
Simona Vetter, David Airlie, Thomas Zimmermann, Maxime Ripard,
Danilo Krummrich, Lyude Paul
No functional changes.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c
index deb6af40ef328..42a6ebbc2e3c3 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/crc.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c
@@ -16,7 +16,6 @@
#include "nouveau_drv.h"
#include "core.h"
#include "head.h"
-#include "wndw.h"
#include "handles.h"
#include "crc.h"
base-commit: 29d6da40d0b8bf3bbc3dcd1d2198434a0e1f71b0
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Claude review: drm/nouveau/kms/nvd9-: Remove unused header in crc.c
2026-05-01 21:57 [PATCH] drm/nouveau/kms/nvd9-: Remove unused header in crc.c Lyude Paul
2026-05-04 23:07 ` Claude review: " Claude Code Review Bot
@ 2026-05-04 23:07 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-05-04 23:07 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: drm/nouveau/kms/nvd9-: Remove unused header in crc.c
Author: Lyude Paul <lyude@redhat.com>
Patches: 1
Reviewed: 2026-05-05T09:07:11.262906
---
This is a single trivial cleanup patch that removes an unused `#include "wndw.h"` from `drivers/gpu/drm/nouveau/dispnv50/crc.c`. The change is correct and harmless.
**Verdict: Looks good.** No functional impact, no risk.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Claude review: drm/nouveau/kms/nvd9-: Remove unused header in crc.c
2026-05-01 21:57 [PATCH] drm/nouveau/kms/nvd9-: Remove unused header in crc.c Lyude Paul
@ 2026-05-04 23:07 ` Claude Code Review Bot
2026-05-04 23:07 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-05-04 23:07 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Status: Clean**
The patch removes the unused include:
```c
-#include "wndw.h"
```
I verified that `crc.c` contains zero references to any symbol exported by `wndw.h` — no use of `struct nv50_wndw`, `struct nv50_wndw_func`, `nv50_wndw()`, or any of the `wndwc*` / `base507c*` function declarations. The remaining includes (`nouveau_drv.h`, `core.h`, `head.h`, `handles.h`, `crc.h`) are sufficient for everything `crc.c` needs.
**Minor nit on the subject line:** The subject says "nvd9-" (suggesting GF119+), but the file path is `dispnv50/` which covers NV50 and later. The "nvd9-" scope qualifier in the subject seems to refer to the CRC feature's hardware support range rather than the file location, which is fine, but could be slightly confusing since the file itself is shared across the dispnv50 code.
**No issues found.** Reviewed-by worthy as-is.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-04 23:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-01 21:57 [PATCH] drm/nouveau/kms/nvd9-: Remove unused header in crc.c Lyude Paul
2026-05-04 23:07 ` Claude review: " Claude Code Review Bot
2026-05-04 23:07 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox