From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/exynos: fbdev: Remove offset into screen_buffer
Date: Sat, 16 May 2026 15:38:04 +1000 [thread overview]
Message-ID: <review-patch1-20260511115538.57884-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20260511115538.57884-2-tzimmermann@suse.de>
Patch Review
**Status: Good**
This is a straightforward bugfix. The `screen_buffer` field in `struct fb_info` should point to the start of framebuffer memory, not to an offset within it. The `xoffset`/`yoffset` values describe scrolling during scanout and should not be baked into the base address.
```c
- offset = fbi->var.xoffset * fb->format->cpp[0];
- offset += fbi->var.yoffset * fb->pitches[0];
...
- fbi->screen_buffer = exynos_gem->kvaddr + offset;
+ fbi->screen_buffer = exynos_gem->kvaddr;
```
The Fixes tag and stable Cc are appropriate. The offsets are typically 0 at fbdev setup time anyway (`drm_fb_helper_fill_info` sets `var.xoffset = var.yoffset = 0`), so this was mostly a latent bug rather than a functional regression, but still worth fixing for correctness.
No concerns.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 5:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 11:54 [PATCH v3 0/5] drm/exynos: fbdev: Use client buffers Thomas Zimmermann
2026-05-11 11:54 ` [PATCH v3 1/5] drm/exynos: fbdev: Remove offset into screen_buffer Thomas Zimmermann
2026-05-16 5:38 ` Claude Code Review Bot [this message]
2026-05-11 11:54 ` [PATCH v3 2/5] drm/exynos: fbdev: Inline exynos_drm_fbdev_update() Thomas Zimmermann
2026-05-16 5:38 ` Claude review: " Claude Code Review Bot
2026-05-11 11:54 ` [PATCH v3 3/5] drm/exynos: fbdev: Calculate buffer geometry with format helpers Thomas Zimmermann
2026-05-16 5:38 ` Claude review: " Claude Code Review Bot
2026-05-11 11:54 ` [PATCH v3 4/5] drm/exynos: fbdev: Use a DRM client buffer Thomas Zimmermann
2026-05-16 5:38 ` Claude review: " Claude Code Review Bot
2026-05-11 11:54 ` [PATCH v3 5/5] drm/exynos: Make exynos_drm_framebuffer_init() an internal interface Thomas Zimmermann
2026-05-16 5:38 ` Claude review: " Claude Code Review Bot
2026-05-16 5:38 ` Claude review: drm/exynos: fbdev: Use client buffers Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260511115538.57884-2-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox