public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/exynos: fbdev: Inline exynos_drm_fbdev_update()
Date: Sat, 16 May 2026 15:38:04 +1000	[thread overview]
Message-ID: <review-patch2-20260511115538.57884-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20260511115538.57884-3-tzimmermann@suse.de>

Patch Review

**Status: Good**

`exynos_drm_fbdev_update()` was a single-caller function that always returned 0. Inlining it removes the `err_destroy_framebuffer` error label, which was dead code since the function could never fail.

The inlined assignments are all non-failable:
```c
+	info->fbops = &exynos_drm_fb_ops;
+	drm_fb_helper_fill_info(info, helper, sizes);
+	info->flags |= FBINFO_VIRTFB;
+	info->screen_buffer = exynos_gem->kvaddr;
+	info->screen_size = size;
+	info->fix.smem_len = size;
```

Removing the dead `err_destroy_framebuffer` path is correct — if something failed here (it can't), the fbdev teardown via `fb_destroy` would clean up the framebuffer anyway.

No concerns.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  5:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 11:54 [PATCH v3 0/5] drm/exynos: fbdev: Use client buffers Thomas Zimmermann
2026-05-11 11:54 ` [PATCH v3 1/5] drm/exynos: fbdev: Remove offset into screen_buffer Thomas Zimmermann
2026-05-16  5:38   ` Claude review: " Claude Code Review Bot
2026-05-11 11:54 ` [PATCH v3 2/5] drm/exynos: fbdev: Inline exynos_drm_fbdev_update() Thomas Zimmermann
2026-05-16  5:38   ` Claude Code Review Bot [this message]
2026-05-11 11:54 ` [PATCH v3 3/5] drm/exynos: fbdev: Calculate buffer geometry with format helpers Thomas Zimmermann
2026-05-16  5:38   ` Claude review: " Claude Code Review Bot
2026-05-11 11:54 ` [PATCH v3 4/5] drm/exynos: fbdev: Use a DRM client buffer Thomas Zimmermann
2026-05-16  5:38   ` Claude review: " Claude Code Review Bot
2026-05-11 11:54 ` [PATCH v3 5/5] drm/exynos: Make exynos_drm_framebuffer_init() an internal interface Thomas Zimmermann
2026-05-16  5:38   ` Claude review: " Claude Code Review Bot
2026-05-16  5:38 ` Claude review: drm/exynos: fbdev: Use client buffers Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260511115538.57884-3-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox