public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: platform/surface: gpe: use platform_device_register_full()
Date: Sat, 16 May 2026 13:28:29 +1000	[thread overview]
Message-ID: <review-patch1-20260512-swnode-remove-on-dev-unreg-v5-1-0035eff63812@oss.qualcomm.com> (raw)
In-Reply-To: <20260512-swnode-remove-on-dev-unreg-v5-1-0035eff63812@oss.qualcomm.com>

Patch Review

The init path conversion is clean — replacing manual `fwnode_create_software_node()` + `platform_device_alloc()` + `platform_device_add()` with a single `platform_device_register_full()` call via `.properties` is a nice simplification.

**Bug: `surface_gpe_exit()` is not updated and becomes a use-after-free.**

The current exit function (unchanged by this patch) does:
```c
static void __exit surface_gpe_exit(void)
{
    struct fwnode_handle *fwnode = surface_gpe_device->dev.fwnode;
    platform_device_unregister(surface_gpe_device);
    platform_driver_unregister(&surface_gpe_driver);
    fwnode_remove_software_node(fwnode);
}
```

After this patch, `.properties` in `pdevinfo` causes `platform_device_register_full()` to call `device_create_managed_software_node()`. A managed swnode is automatically freed during `software_node_notify_remove()` (called from `device_del()` inside `platform_device_unregister()`). At that point, `fwnode` is a dangling pointer, and the subsequent `fwnode_remove_software_node(fwnode)` is a use-after-free.

The exit function must be updated to remove the manual `fwnode_remove_software_node()` call, since the managed node is cleaned up automatically by the unregister path. Something like:

```c
static void __exit surface_gpe_exit(void)
{
    platform_device_unregister(surface_gpe_device);
    platform_driver_unregister(&surface_gpe_driver);
}
```

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  3:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 11:59 [PATCH v5 0/7] driver core: remove software node from platform devices on device release Bartosz Golaszewski
2026-05-12 11:59 ` [PATCH v5 1/7] platform/surface: gpe: use platform_device_register_full() Bartosz Golaszewski
2026-05-16  3:28   ` Claude Code Review Bot [this message]
2026-05-12 11:59 ` [PATCH v5 2/7] driver core: platform: make the swnode check stricter Bartosz Golaszewski
2026-05-16  3:28   ` Claude review: " Claude Code Review Bot
2026-05-12 11:59 ` [PATCH v5 3/7] driver core: platform: provide platform_device_add_software_node() Bartosz Golaszewski
2026-05-12 16:31   ` Danilo Krummrich
2026-05-12 18:15     ` Dmitry Torokhov
2026-05-13 11:55     ` Bartosz Golaszewski
2026-05-16  3:28   ` Claude review: " Claude Code Review Bot
2026-05-12 11:59 ` [PATCH v5 4/7] drm/xe/i2c: use platform_device_add_software_node() Bartosz Golaszewski
2026-05-12 16:24   ` Danilo Krummrich
2026-05-16  3:28   ` Claude review: " Claude Code Review Bot
2026-05-12 11:59 ` [PATCH v5 5/7] driver core: platform: remove software node on release() Bartosz Golaszewski
2026-05-16  3:28   ` Claude review: " Claude Code Review Bot
2026-05-12 11:59 ` [PATCH v5 6/7] kunit: provide kunit_software_node_register() Bartosz Golaszewski
2026-05-12 15:28   ` Andy Shevchenko
2026-05-16  3:28   ` Claude review: " Claude Code Review Bot
2026-05-12 11:59 ` [PATCH v5 7/7] driver core: platform: tests: add test cases for correct swnode removal Bartosz Golaszewski
2026-05-16  3:28   ` Claude review: " Claude Code Review Bot
2026-05-12 15:07 ` [PATCH v5 0/7] driver core: remove software node from platform devices on device release Danilo Krummrich
2026-05-16  3:28 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-13 15:04 [PATCH v6 0/6] " Bartosz Golaszewski
2026-05-13 15:04 ` [PATCH v6 2/6] platform/surface: gpe: use platform_device_register_full() Bartosz Golaszewski
2026-05-16  1:52   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260512-swnode-remove-on-dev-unreg-v5-1-0035eff63812@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox