public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Introduce dmem driver and implement Xe support
Date: Sat, 16 May 2026 12:42:31 +1000	[thread overview]
Message-ID: <review-patch1-20260512215156.4083082-2-cascardo@igalia.com> (raw)
In-Reply-To: <20260512215156.4083082-2-cascardo@igalia.com>

Patch Review

Good abstraction. The vtable in `igt_dmem_driver.h` is clean and minimal.

**Issue: `xe_dmem_allocate_vram` leaks BO on bind failure.**
If `__xe_vm_bind_lr_sync` fails, the handle is stored in `xe_ctx->handles[n_bo]` but never closed:

```c
err = __xe_bo_create(xe_ctx->fd, 0, len, xe_ctx->vram_region,
                     DRM_XE_GEM_CREATE_FLAG_DEFER_BACKING,
                     NULL, &handle);
if (err)
    goto out;

xe_ctx->handles[n_bo] = handle;

err = __xe_vm_bind_lr_sync(xe_ctx->fd, xe_ctx->vm, handle, 0,
                           xe_ctx->addr, len, 0);
if (err)
    goto out;  /* handle stored but addr not incremented, BO not closed */
```

When bind fails, the caller sees the error and stops, but `free_vram` walks `handles[0..n_bo-1]` and will try to unbind at an address that was never bound. The stored handle will get a `gem_close` which is fine, but the `xe_vm_unbind_lr_sync` for that address will fail or operate on wrong memory. Consider closing the handle on bind failure, or at minimum zeroing the handle entry.

**Issue: `xe_ctx->addr` is monotonically increasing.** After `xe_dmem_free_vram`, `addr` is not reset. This means subsequent `allocate_vram` calls bind at ever-higher VAs. For the existing eviction test (single allocate/free cycle) this is fine, but the new `test_current` in patch 6 does three allocate/free cycles, which will consume `3 * cg_max` worth of VA space. Not fatal, but wasteful and could theoretically exhaust the VA range on very large VRAM systems.

**Minor: Error code mismatch in `xe_dmem_init`.** When no VRAM region is found, the function returns `-ENOMEM`, which is misleading. Something like `-ENODEV` would be more appropriate.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  2:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 21:51 [PATCH i-g-t 0/8] dmem: add amdgpu support and one more test Thadeu Lima de Souza Cascardo
2026-05-12 21:51 ` [PATCH i-g-t 1/8] Introduce dmem driver and implement Xe support Thadeu Lima de Souza Cascardo
2026-05-16  2:42   ` Claude Code Review Bot [this message]
2026-05-12 21:51 ` [PATCH i-g-t 2/8] Adjust xe_cgroups test to use igt_dmem_driver Thadeu Lima de Souza Cascardo
2026-05-13 15:18   ` Kamil Konieczny
2026-05-16  2:42   ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 3/8] Make xe_cgroup test a generic test Thadeu Lima de Souza Cascardo
2026-05-13 15:21   ` Kamil Konieczny
2026-05-16  2:42   ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 4/8] amdgpu: add amdgpu_cgroup_region_name Thadeu Lima de Souza Cascardo
2026-05-16  2:42   ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 5/8] igt_dmem_driver: add amdgpu support Thadeu Lima de Souza Cascardo
2026-05-13 15:26   ` Kamil Konieczny
2026-05-16  2:42   ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 6/8] dmem: add test for current/max Thadeu Lima de Souza Cascardo
2026-05-13 15:31   ` Kamil Konieczny
2026-05-16  2:42   ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 7/8] dmem: only check for dmem availability once Thadeu Lima de Souza Cascardo
2026-05-16  2:42   ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 8/8] dmem: get region once per driver Thadeu Lima de Souza Cascardo
2026-05-16  2:42   ` Claude review: " Claude Code Review Bot
2026-05-12 22:27 ` [PATCH i-g-t 0/8] dmem: add amdgpu support and one more test Thadeu Lima de Souza Cascardo
2026-05-13  8:06 ` Christian König
2026-05-13  8:54   ` Thomas Hellström
2026-05-16  2:42 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260512215156.4083082-2-cascardo@igalia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox