From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dmem: add test for current/max
Date: Sat, 16 May 2026 12:42:33 +1000 [thread overview]
Message-ID: <review-patch6-20260512215156.4083082-7-cascardo@igalia.com> (raw)
In-Reply-To: <20260512215156.4083082-7-cascardo@igalia.com>
Patch Review
**Bug: Inverted assertion at max=0 test.**
```c
igt_cgroup_dmem_set_max(cg, cg_region, 0);
n_bo = allocate_vram(drv, ctx, fd, max_bo, BO_SIZE);
igt_assert_f(n_bo != -ENOMEM, "VRAM allocation succeeded despite max set to 0\n");
```
`allocate_vram` returns negative error on failure, or positive n_bo count on success. With `max=0`, Xe should reject the allocation with `-ENOMEM`. The assertion `n_bo != -ENOMEM` is **false** when allocation correctly fails, so the test will fire `igt_assert_f` and abort with the message "VRAM allocation succeeded despite max set to 0" -- but the allocation actually *failed*, which is the expected behavior.
This should probably be:
```c
igt_assert_f(n_bo <= 0, "VRAM allocation succeeded despite max set to 0\n");
```
Or, since amdgpu may succeed by falling back to GTT:
```c
/* Xe: allocation should fail; amdgpu: may succeed via GTT fallback */
```
with appropriate per-driver logic.
**Issue: stale context reuse across allocate/free cycles.** The test does:
1. `drv->init(&ctx, ...)` with `max_bo = cg_max / BO_SIZE`
2. `allocate_vram(... max_bo ...)` -- uses handles[0..n_bo-1]
3. `drv->free_vram(ctx, n_bo, BO_SIZE)` -- frees those BOs
4. `allocate_vram(... max_bo ...)` -- reuses handles[0..n_bo-1] (OK)
5. `drv->free_vram(ctx, n_bo, BO_SIZE)` -- frees again
6. `allocate_vram(... max_bo ...)` -- third round
For Xe, each `allocate_vram` call increments `xe_ctx->addr` but `free_vram` doesn't reset it (as noted in patch 1 review). After three rounds, we've consumed `~3 * 4GiB = 12GiB` of VA space starting from `BIND_BASE` (4 GiB). This works but is fragile.
**Nit: `sleep(1)` after free.** This is a heuristic wait for the kernel to update cgroup accounting. It's common in IGT but fragile -- consider using a polling helper like the existing `wait_for_usage_drop` if available.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 2:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 21:51 [PATCH i-g-t 0/8] dmem: add amdgpu support and one more test Thadeu Lima de Souza Cascardo
2026-05-12 21:51 ` [PATCH i-g-t 1/8] Introduce dmem driver and implement Xe support Thadeu Lima de Souza Cascardo
2026-05-16 2:42 ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 2/8] Adjust xe_cgroups test to use igt_dmem_driver Thadeu Lima de Souza Cascardo
2026-05-13 15:18 ` Kamil Konieczny
2026-05-16 2:42 ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 3/8] Make xe_cgroup test a generic test Thadeu Lima de Souza Cascardo
2026-05-13 15:21 ` Kamil Konieczny
2026-05-16 2:42 ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 4/8] amdgpu: add amdgpu_cgroup_region_name Thadeu Lima de Souza Cascardo
2026-05-16 2:42 ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 5/8] igt_dmem_driver: add amdgpu support Thadeu Lima de Souza Cascardo
2026-05-13 15:26 ` Kamil Konieczny
2026-05-16 2:42 ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 6/8] dmem: add test for current/max Thadeu Lima de Souza Cascardo
2026-05-13 15:31 ` Kamil Konieczny
2026-05-16 2:42 ` Claude Code Review Bot [this message]
2026-05-12 21:51 ` [PATCH i-g-t 7/8] dmem: only check for dmem availability once Thadeu Lima de Souza Cascardo
2026-05-16 2:42 ` Claude review: " Claude Code Review Bot
2026-05-12 21:51 ` [PATCH i-g-t 8/8] dmem: get region once per driver Thadeu Lima de Souza Cascardo
2026-05-16 2:42 ` Claude review: " Claude Code Review Bot
2026-05-12 22:27 ` [PATCH i-g-t 0/8] dmem: add amdgpu support and one more test Thadeu Lima de Souza Cascardo
2026-05-13 8:06 ` Christian König
2026-05-13 8:54 ` Thomas Hellström
2026-05-16 2:42 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260512215156.4083082-7-cascardo@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox