From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: verisilicon: fix build failure of cursor plane code
Date: Tue, 26 May 2026 06:48:27 +1000 [thread overview]
Message-ID: <review-patch1-20260525153618.1336239-1-zhengxingda@iscas.ac.cn> (raw)
In-Reply-To: <20260525153618.1336239-1-zhengxingda@iscas.ac.cn>
Patch Review
**Status: Looks good**
The patch changes the second parameter of four plane atomic hooks from `struct drm_atomic_state *` to `struct drm_atomic_commit *`:
1. `vs_cursor_plane_atomic_check` — confirmed matches vtable signature at `drm_modeset_helper_vtables.h:1311`
2. `vs_cursor_plane_atomic_enable` — confirmed matches vtable signature at `drm_modeset_helper_vtables.h:1353`
3. `vs_cursor_plane_atomic_disable` — confirmed matches vtable signature at `drm_modeset_helper_vtables.h:1378`
4. `vs_cursor_plane_atomic_update` — confirmed matches vtable signature at `drm_modeset_helper_vtables.h:1328`
All four functions pass `state`/`atomic_state` directly to `drm_atomic_get_new_plane_state()` or `drm_atomic_get_old_plane_state()`, both of which already take `const struct drm_atomic_commit *` (confirmed at `drm_atomic.h:824` and `drm_atomic.h:809`). So the type change is sufficient and no other code in the function bodies needs updating.
The commit message clearly explains the situation — the cursor plane patch was stalled long enough that the rename happened underneath it.
The `Fixes:` tag correctly references the commit that introduced the stale type.
No concerns with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 15:36 [PATCH drm-misc-next] drm: verisilicon: fix build failure of cursor plane code Icenowy Zheng
2026-05-25 20:48 ` Claude Code Review Bot [this message]
2026-05-25 20:48 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260525153618.1336239-1-zhengxingda@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox